Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ANSI HTML-ifying to the site #478

Closed
Xyene opened this issue Sep 15, 2019 · 1 comment
Closed

Move ANSI HTML-ifying to the site #478

Xyene opened this issue Sep 15, 2019 · 1 comment
Labels
enhancement security
Milestone
2.0.0

Comments

@Xyene
Copy link
Member

Xyene commented Sep 15, 2019 •
edited
Loading

The judge formats compiler ANSI codes as HTML, which are then sent to the site, where they rendered as "safe" (unescaped).

Some problems with this were recognized from the start, but the ease of implementation all those years ago outweighed doing it right. In particular,

  • Judges have to be trusted to not output things like script tags into the compiler output section
  • There is no future control over the mapping from ANSI code to color; this makes wishlist items like a dark mode significantly harder to implement
  • There is some (small) database bloat from storing HTML tags rather than ANSI codes

Moving forward, we should fix this. A possible solution is to write a migration that strips HTML tags from old compiler outputs, and start sending ANSI codes instead.
@Xyene Xyene added this to the 1.5.0 milestone Sep 15, 2019
Xyene added a commit that referenced this issue Sep 16, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
e25f509
@Xyene Xyene mentioned this issue Sep 16, 2019
Merged
Xyene added a commit that referenced this issue Sep 16, 2019
@Xyene
Patch up race condition exposed in #478
ad6a9a5
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Sep 17, 2019
@Ninjaclasher
Move ANSI HTML-ifying to site; DMOJ/judge-server#478
0a0a0db
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Sep 17, 2019
@Ninjaclasher
Move ANSI HTML-ifying to site; DMOJ/judge-server#478
9cec1f3
Xyene added a commit that referenced this issue Sep 17, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
4cb878f
Xyene added a commit that referenced this issue Sep 17, 2019
@Xyene
Patch up race condition exposed in #478
c267b56
Xyene added a commit that referenced this issue Sep 17, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
c3c0a94
Xyene added a commit that referenced this issue Sep 17, 2019
@Xyene
Patch up race condition exposed in #478
6fc7538
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Sep 17, 2019
@Ninjaclasher
Move ANSI HTML-ifying to site; DMOJ/judge-server#478
fd63453
Xyene added a commit that referenced this issue Sep 17, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
0c971a4
Xyene added a commit that referenced this issue Sep 17, 2019
@Xyene
Patch up race condition exposed in #478
84ae761
Xyene added a commit that referenced this issue Sep 17, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
17c9793
Xyene added a commit that referenced this issue Sep 17, 2019
@Xyene
Patch up race condition exposed in #478
016fc43
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Sep 18, 2019
@Ninjaclasher
Move ANSI HTML-ifying to site; DMOJ/judge-server#478
8515eb2
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Sep 28, 2019
@Ninjaclasher
Move ANSI HTML-ifying to site; DMOJ/judge-server#478
582e621
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Sep 29, 2019
@Ninjaclasher
Move ANSI HTML-ifying to site; DMOJ/judge-server#478
56729a2
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Sep 29, 2019
@Ninjaclasher
Move ANSI HTML-ifying to site; DMOJ/judge-server#478
fb15453
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
a9522b9
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Patch up race condition exposed in #478
9e6b697
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
21bce9b
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Patch up race condition exposed in #478
b22cb47
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
a6a1a74
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Patch up race condition exposed in #478
59d7b83
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
25daacb
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Patch up race condition exposed in #478
f89e6ac
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Send raw compiler ANSI output to the site; #478
0d61e5b
Xyene added a commit that referenced this issue Sep 29, 2019
@Xyene
Patch up race condition exposed in #478
eae8514
Xyene pushed a commit to DMOJ/online-judge that referenced this issue Sep 29, 2019
@Ninjaclasher @Xyene
Move ANSI HTML-ifying to site; DMOJ/judge-server#478
e5297dd
Xyene added a commit to DMOJ/online-judge that referenced this issue Sep 29, 2019
@Xyene
Output of ansi2html must be marked safe; DMOJ/judge-server#478
761aa48
Xyene added a commit to DMOJ/online-judge that referenced this issue Sep 29, 2019
@Xyene
Output of ansi2html must be marked safe; DMOJ/judge-server#478
0184aa7
@Xyene
Copy link
Member Author

Xyene commented Sep 29, 2019

This is complete and live.

@Xyene Xyene closed this as completed Sep 29, 2019
malbareda pushed a commit to malbareda/JOEL-web that referenced this issue Jan 4, 2024
@Ninjaclasher @Xyene
Move ANSI HTML-ifying to site; DMOJ/judge-server#478
c79be35
malbareda pushed a commit to malbareda/JOEL-web that referenced this issue Jan 4, 2024
@Xyene
Output of ansi2html must be marked safe; DMOJ/judge-server#478
f809ccb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement security
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@Xyene