Select additional submission options page #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demwunz
force-pushed
the
WATER-4306-select-additional-submission-options-page-layout-and-controls
branch
from
9e546d7 to
7921d8a
Compare
https://eaflood.atlassian.net/browse/WATER-4306 Additional options for submission page. This will provide option for multiple upload, or none. Appropriate notifications will be shown to user based on selection.
Demwunz
force-pushed
the
WATER-4306-select-additional-submission-options-page-layout-and-controls
branch
from
7921d8a to
4254b22
Compare
Demwunz
force-pushed
the
WATER-4306-select-additional-submission-options-page-layout-and-controls
branch
from
cb81efb to
55b9d35
Compare
…ons-page-layout-and-controls
Demwunz
force-pushed
the
WATER-4306-select-additional-submission-options-page-layout-and-controls
branch
from
a0bf2d5 to
79329a8
Compare
Demwunz
force-pushed
the
WATER-4306-select-additional-submission-options-page-layout-and-controls
branch
from
79329a8 to
10791ed
Compare
…ons-page-layout-and-controls
…ons-page-layout-and-controls
Demwunz
force-pushed
the
WATER-4306-select-additional-submission-options-page-layout-and-controls
branch
from
c072acd to
355386a
Compare
Cruikshanks
requested changes
May 15, 2024
There was a problem hiding this comment.
I don't often say this, but I think we might have too many tests! 😂
If you really think we should be testing both setting and updating values in our pages do please argue the case. But be warned, if I end up agreeing then the principle applies to all the other pages! 😜
test/services/return-requirements/submit-additional-submission-options.service.test.js
Show resolved
Hide resolved
…ons-page-layout-and-controls
Demwunz
force-pushed
the
WATER-4306-select-additional-submission-options-page-layout-and-controls
branch
from
e413ac8 to
f3a5fe8
Compare
Cruikshanks
requested changes
May 16, 2024
There was a problem hiding this comment.
Really sorry @Demwunz I should have spotted the single option select thing on my first pass.
app/services/return-requirements/submit-additional-submission-options.service.js
Outdated
Show resolved
Hide resolved
test/services/return-requirements/submit-additional-submission-options.service.test.js
Outdated
Show resolved
Hide resolved
…ons-page-layout-and-controls
…ons-page-layout-and-controls
Demwunz
force-pushed
the
WATER-4306-select-additional-submission-options-page-layout-and-controls
branch
from
ce76694 to
64b40b2
Compare
Cruikshanks
requested changes
May 16, 2024
| @@ -10,6 +10,7 @@ const AddService = require('../services/return-requirements/add.service.js') | |||
| const AgreementsExceptionsService = require('../services/return-requirements/agreements-exceptions.service.js') | |||
| const CancelService = require('../services/return-requirements/cancel.service.js') | |||
| const CheckService = require('../services/return-requirements/check.service.js') | |||
| const AdditionalSubmissionOptionsService = require('../services/return-requirements/additional-submission-options.service.js') | |||
There was a problem hiding this comment.
NIT - think this just needs to go up a few lines to be under AbstractionPeriodService.
Comment on lines
57
to
60
| * When a single agreement and exception is checked by the user, it returns as a string. When multiple agreements and | ||
| * exceptions are checked, the 'additionalSubmissionOptions' is returned as an array. | ||
| * This function works to make those single | ||
| * selected string 'additionalSubmissionOptions' into an array for uniformity. |
There was a problem hiding this comment.
Just needs an update after the copy and paste.
Suggested change
| * When a single agreement and exception is checked by the user, it returns as a string. When multiple agreements and | |
| * exceptions are checked, the 'additionalSubmissionOptions' is returned as an array. | |
| * This function works to make those single | |
| * selected string 'additionalSubmissionOptions' into an array for uniformity. | |
| * When a single additional submission option is checked by the user, it returns as a string. When multiple options are | |
| * checked, the 'additionalSubmissionOptions' is returned as an array. This function works to make those single selected | |
| * string 'additionalSubmissionOptions' into an array for uniformity. |
Comment on lines
23
to
28
| /** | ||
| * NOTE: When a single point is checked by a user, it returns as a string. | ||
| * When multiple additionalSubmissionOptions are checked, the 'payload' is returned as an array. | ||
| * To make Joi validation straightforward, if the "payload.additionalSubmissionOptions" is a string, | ||
| * it is turned into an array and validated as such. | ||
| */ |
There was a problem hiding this comment.
I think this comment can be deleted now.
Suggested change
| /** | |
| * NOTE: When a single point is checked by a user, it returns as a string. | |
| * When multiple additionalSubmissionOptions are checked, the 'payload' is returned as an array. | |
| * To make Joi validation straightforward, if the "payload.additionalSubmissionOptions" is a string, | |
| * it is turned into an array and validated as such. | |
| */ |
…ons-page-layout-and-controls
Cruikshanks
approved these changes
May 17, 2024
Demwunz
deleted the
WATER-4306-select-additional-submission-options-page-layout-and-controls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4306
Additional options for submission page.
This branch will provide options for "multiple upload", or "none".
Appropriate notifications will be shown to user based on selection.