feat(app): remove redundant comments

DEFRA · May 15, 2024 · 10791ed · 10791ed
1 parent c06f337
commit 10791ed
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/app/presenters/return-requirements/additional-submission-options.presenter.js b/app/presenters/return-requirements/additional-submission-options.presenter.js
@@ -9,8 +9,6 @@
  * Formats data for the `/return-requirements/{sessionId}/additional-submission-options` page
  *
  * @param {module:SessionModel} session - The returns requirements session instance
- * @param {string} requirementIndex - The index of the requirement being added or changed
- * @param {Object} [payload] - The payload from the request
  *
  * @returns {Object} - The data formatted for the view template
  */

diff --git a/app/services/return-requirements/submit-additional-submission-options.service.js b/app/services/return-requirements/submit-additional-submission-options.service.js
@@ -20,7 +20,6 @@ const SessionModel = require('../../models/session.model.js')
  *
  * @param {string} sessionId - The id of the current session
  * @param {Object} payload - The submitted form data
- * @param {string} requirementIndex - The index of the requirement being added or changed
  * @param {Object} yar - The Hapi `request.yar` session manager passed on by the controller
  *
  * @returns {Promise<Object>} If no errors it returns an empty object else the page data for the note page including the

diff --git a/test/presenters/return-requirements/additional-submission-options.presenter.test.js b/test/presenters/return-requirements/additional-submission-options.presenter.test.js
@@ -37,10 +37,11 @@ describe('Return Requirements - Additional Submission Options presenter', () =>
       const result = AdditionalSubmissionOptionsPresenter.go(session)
 
       expect(result).to.be.equal({
-        backLink: '/system/return-requirements/61e07498-f309-4829-96a9-72084a54996d/check',
+        backLink: `/system/return-requirements/${session.id}/check`,
         licenceId: '8b7f78ba-f3ad-4cb6-a058-78abc4d1383d',
         additionalSubmissionOptions: '',
-        licenceRef: '01/ABC'
+        licenceRef: '01/ABC',
+        sessionId: session.id
       })
     })
   })
@@ -49,7 +50,7 @@ describe('Return Requirements - Additional Submission Options presenter', () =>
     it("returns a link back to the 'check' page", () => {
       const result = AdditionalSubmissionOptionsPresenter.go(session)
 
-      expect(result.backLink).to.equal('/system/return-requirements/61e07498-f309-4829-96a9-72084a54996d/check')
+      expect(result.backLink).to.equal(`/system/return-requirements/${session.id}/check`)
     })
   })
 

diff --git a/test/services/return-requirements/submit-additional-submission-options.service.test.js b/test/services/return-requirements/submit-additional-submission-options.service.test.js
@@ -136,6 +136,7 @@ describe('Return Requirements - Submit Additional Submission Options service', (
 
         expect(result).to.equal({
           activeNavBar: 'search',
+          backLink: `/system/return-requirements/${session.id}/check`,
           pageTitle: 'Select any additional submission options for the return requirements',
           licenceRef: '01/ABC',
           additionalSubmissionOptions: [undefined]