Migrate view bill runs page from legacy UI #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4445 > Part of a series of changes to migrate the legacy view bill runs page into this project This is the final step in migrating the legacy view bill runs page to this project. We dealt with the support services we need in previous changes. Now we need to add - the route - the controller handler - the orchestration service - the view template We also update the menu to point to it and not the legacy `/billing/batch/list`. Worth noting (because this is the first) we use the convention of naming the handler and subsequent files `index` to reflect they deal with displaying a list of bill runs, not a single one.
Cruikshanks
force-pushed
the
migrate-view-bill-runs
branch
from
ffe5929 to
ae3bd2a
Compare
Cruikshanks
force-pushed
the
migrate-view-bill-runs
branch
from
ae3bd2a to
0c34cb8
Compare
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
Cruikshanks
removed request for
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
Brings the macro inline with review status and allows us to support inline tags.
Cruikshanks
added a commit
to DEFRA/water-abstraction-ui
that referenced
this pull request
Apr 22, 2024
https://eaflood.atlassian.net/browse/WATER-4445 > Part of a series of changes to migrate the legacy view bill runs page into this project This changes updates all links in the legacy UI project to `/billing/batch/list` to use `/system/bill-runs` instead. Once [Migrate view bill runs page from legacy UI](DEFRA/water-abstraction-system#925) is merged the view will be considered migrated.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
Great feedback in the PR highlighted we were not testing the link generated worked for bill runs in 'review'. This adds that test.
The feedback about checking we were generating the href correctly for bill runs with a 'review' status reminded us we were not properly handling bill runs with a 'cancel' status. No link should be displayed for these (there is a good chance the bill run will be gone by the time someone clicks the link). This change covers that omission.
Cruikshanks
added a commit
to DEFRA/water-abstraction-ui
that referenced
this pull request
Apr 24, 2024
https://eaflood.atlassian.net/browse/WATER-4445 > Part of a series of changes to migrate the legacy view bill runs page into this project This change updates all links in the legacy UI project to `/billing/batch/list` to use `/system/bill-runs` instead. Once [Migrate view bill runs page from legacy UI](DEFRA/water-abstraction-system#925) is merged the view will be considered migrated.
Cruikshanks
added a commit
to DEFRA/water-abstraction-acceptance-tests
that referenced
this pull request
Apr 29, 2024
https://eaflood.atlassian.net/browse/WATER-4445 In [Migrate view bill runs page from legacy UI](DEFRA/water-abstraction-system#925) we were able to implement a new version of the bill runs page! But that means we need to update any tests that interact with it to use the new selectors we have made available.
Cruikshanks
added a commit
that referenced
this pull request
Apr 30, 2024
https://eaflood.atlassian.net/browse/WATER-4445 In [Migrate view bill runs page from legacy UI](#925) we were able to implement a new version of the bill runs page! But our QA team have spotted that the links to PRESROC bill runs that are in `review` are broken. The links we generate are for our review page when they should be for the legacy one. This change fixes the issue.
Cruikshanks
added a commit
that referenced
this pull request
Apr 30, 2024
https://eaflood.atlassian.net/browse/WATER-4445 In [Migrate view bill runs page from legacy UI](#925) we were able to implement a new version of the bill runs page! However, our QA team have spotted that the links to PRESROC bill runs that are in `review` are broken. The links we generate are for our review page when they should be for the legacy one. This change fixes the issue.
Cruikshanks
added a commit
to DEFRA/water-abstraction-acceptance-tests
that referenced
this pull request
Apr 30, 2024
https://eaflood.atlassian.net/browse/WATER-4445 In [Migrate view bill runs page from legacy UI](DEFRA/water-abstraction-system#925) we were able to implement a new version of the bill runs page! But that means we need to update any tests that interact with it to use the new selectors we have made available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4445
This is the final step in migrating the legacy view bill runs page to this project. We dealt with the support services we need in previous changes. Now we need to add
We also update the menu to point to it and not the legacy
/billing/batch/list. Worth noting (because this is the first) we use the convention of naming the handler and subsequent filesindexto reflect they deal with displaying a list of bill runs, not a single one.