Update tests for new bill runs page #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4445 In [Migrate view bill runs page from legacy UI](DEFRA/water-abstraction-system#925) we were able to implement a new version of the bill runs page! But that means we need to update any tests that interact with it to use the new selectors we have made available.
Cruikshanks
added
the
housekeeping
Use new data-test attributes wherever possible. Also, realised we kept including asserts inside getters to local variables, for example
```javascript
cy.get('@formattedCurrentDate').then((formattedCurrentDate) => {
cy.get('tr:nth-child(1)')
.should('contain.text', formattedCurrentDate)
.and('contain.text', 'Test Region')
.and('contain.text', 'Annual')
})
```
We only needed to assert the date value inside the `cy.get('@formattedCurrentDate')` call. But it makes it look like you have to do them all for the test to work for the uninitiated. So, where we have spotted stuff like this we have also fixed it up.
Cruikshanks
force-pushed
the
update-for-new-bill-runs-page
branch
from
f6a8e2e to
b555e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4445
In Migrate view bill runs page from legacy UI we were able to implement a new version of the bill runs page!
But that means we need to update any tests that interact with it to use the new selectors we have made available.