Check your answers page with notes for additions, changes and deletions

[Demwunz]

https://eaflood.atlassian.net/browse/WATER-4291

This feature allows the user to see notifications on the page when a note is added, changed or deleted.

A delete-note service has been added which is accessed via a simple GET request. This will delete any note in the session attached to the requirement.

Notifications are shown using hapi/yar and are immediately removed upon first view on the page.

Screenshots

[Cruikshanks]

A few changes needed and then this will be ship-shape and bristol fashion!

[Cruikshanks]

Wherever we use Sinon we need to add a restore() at the tope level in an afterEach() block.

  afterEach(() => {
    Sinon.restore()
  })

[Cruikshanks]

First, a NIT, adding some whitespace. But also this test is incorrect.

It is currently passing because we never set the property session.note but do set the property session.data.note. If you update the test to check for that it will fail because session.data.note is defined.

You need to do this to fix the test and properly check the note has been deleted.

Suggested change

	await DeleteNoteService.go(session.id, yarStub)
	expect(session.note).to.be.undefined()
	await DeleteNoteService.go(session.id, yarStub)
	const refreshedSession = await session.$query()
	expect(refreshedSession.data.note).to.be.undefined()

However, this still won't pass unless the DeleteNoteService is updated to drop the note property instead of setting it to an empty string.

[Demwunz]

makes sense, updated

[Cruikshanks]

If we want to delete the note we ideally want to put it back to the state it was before we added one in the first place. If that is the case I think you need to call this instead.

Suggested change

	currentData.note = ''
	delete currentData.note

[Demwunz]

I agree, this should have been the approach. updated

[Cruikshanks]