fix(app): address sonarcloud issues

DEFRA · May 1, 2024 · 9228ff3 · 9228ff3
1 parent b7c1a38
commit 9228ff3
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/app/controllers/return-requirements.controller.js b/app/controllers/return-requirements.controller.js
@@ -88,11 +88,9 @@ async function checkYourAnswers (request, h) {
 async function deleteNote (request, h) {
   const { sessionId } = request.params
 
-  const notificationData = await DeleteNoteService.go(sessionId, request.yar)
+  await DeleteNoteService.go(sessionId, request.yar)
 
-  if (notificationData.title) {
-    return h.redirect(`/system/return-requirements/${sessionId}/check-your-answers`)
-  }
+  return h.redirect(`/system/return-requirements/${sessionId}/check-your-answers`)
 }
 
 async function existing (request, h) {

diff --git a/app/services/return-requirements/submit-add-note.service.js b/app/services/return-requirements/submit-add-note.service.js
@@ -54,10 +54,6 @@ async function go (sessionId, payload, user, yar) {
 function _notification (session, newNote) {
   const { data: { note } } = session
 
-  if (note && note.content === newNote) {
-    return ''
-  }
-
   if (!note && newNote) {
     return {
       title: 'Added',

diff --git a/app/views/return-requirements/check-your-answers.njk b/app/views/return-requirements/check-your-answers.njk
@@ -52,7 +52,6 @@
       text: notification.text
     }) }}
   {% endif %}
-
   {# Main heading #}
   <div class="govuk-body">
     <h1 class="govuk-heading-xl govuk-!-margin-bottom-3">