Complete Select existing return requirement page #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
changed the title
Cruikshanks
force-pushed
the
WATER-4283-returns-required-journey-select-existing-requirements-from-page
branch
2 times, most recently
from
c9f8dd9 to
4f84c3f
Compare
https://eaflood.atlassian.net/browse/WATER-4283 This page is part of the "returns-required" journey. This page will allow users to choose an existing return if it already exists. The page will have one, or multiple radio controls to allow the user to choose the appropriate requirement.
SHould really have been done in [Add copy existing rtn req. option to setup journey](#1081) 😬😳
Add the service and basic presenter. Update the view to include displaying the licence ref and then hook up the controller handler to start using our new service.
Build the options from the return versions against the licence in the session.
We were build against the ticket but the title in the UI for return requirements has changed since then.
We have to pass it in our array of return versions to allow us to validate that the one being sent in the post request is one that belongs to the licence in the session.
Will sort that in a subsequent change
Cruikshanks
force-pushed
the
WATER-4283-returns-required-journey-select-existing-requirements-from-page
branch
from
a37184b to
22433c2
Compare
This fetches the existing data and transforms it into a format that is can be used by the return requirements setup journey and its pages. To support this and ensure the service is fully tested, we added a new support seed to create the 'complete' requirements for returns record.
Cruikshanks
force-pushed
the
WATER-4283-returns-required-journey-select-existing-requirements-from-page
branch
from
22433c2 to
7380c3d
Compare
…xisting-requirements-from-page
Cruikshanks
deleted the
WATER-4283-returns-required-journey-select-existing-requirements-from-page
branch
Cruikshanks
added a commit
that referenced
this pull request
Jun 12, 2024
https://eaflood.atlassian.net/browse/WATER-4283 > Part of the work to replace NALD for handling return requirements We want to be able to offer users the option to copy data from an existing return requirement when setting up a new one. We [made the option available](#1081) in the `/setup` page. We then did the actual work of allowing users to select the return requirements to copy and saving them to the session in [Complete Select existing return requirement page](#895). But we've since learnt that the title we used for the page is not right. This change corrects it.
Cruikshanks
added a commit
that referenced
this pull request
Jun 12, 2024
https://eaflood.atlassian.net/browse/WATER-4283 > Part of the work to replace NALD for handling return requirements We want to be able to offer users the option to copy data from an existing return requirement when setting up a new one. We [made the option available](#1081) in the `/setup` page. We then did the actual work of allowing users to select the return requirements to copy and saving them to the session in [Complete Select existing return requirement page](#895). But we've since learned that the title we used for the page is not right. This change corrects it.
Cruikshanks
added a commit
that referenced
this pull request
Jun 17, 2024
https://eaflood.atlassian.net/browse/WATER-4283 > Part of the work to replace NALD for handling return requirements In [Complete Select existing return requirement page](#895) we added the controls and logic to enable a user to copy the return requirements from an existing return version into the session. The H1 title we used though was though to be wrong. So, we [Correct copy existing return req. page title](#1092). When we did that, we also updated the validation message as all our current messages just replay the H1 title. Again however, this was thought to be incorrect. Our UAT team have decided the message we should show when an option is not selected is **Select a previous requirements for returns**. This is that change.
Cruikshanks
added a commit
that referenced
this pull request
Jun 18, 2024
https://eaflood.atlassian.net/browse/WATER-4283 > Part of the work to replace NALD for handling return requirements In [Complete Select existing return requirement page](#895) we added the controls and logic to enable a user to copy the return requirements from an existing return version into the session. The H1 title we used though was though to be wrong. So, we [Correct copy existing return req. page title](#1092). When we did that, we also updated the validation message as all our current messages just replay the H1 title. Again, however, this was thought to be incorrect. Our UAT team has decided the message we should show when an option is not selected is **Select a previous requirements for returns**. This is that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4283
We want to be able to offer users the option to copy data from an existing return requirement when setting up a new one. We made the option available in the
/setuppage.When a user selects this option they'll be taken to the
Select an existing return requirement frompage. This change is about completing that page and the feature.Once the page has completed it's work the user will be redirected to the
/checkpage where they can see the results of their action.