Correct copy existing return req. page title #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4283 > Part of the work to replace NALD for handling return requirements We want to be able to offer users the option to copy data from an existing return requirement when setting up a new one. We [made the option available](#1081) in the `/setup` page. We then did the actual work of allowing users to select the return requirements to copy and saving them to the session in [Complete Select existing return requirement page](#895). But we've since learnt that the title we used for the page is not right. This change corrects it.
Cruikshanks
added
the
housekeeping
Oops! Our validation messages when no value is added are expected to match the page title.
Cruikshanks
requested review from
jonathangoulding,
Beckyrose200,
rvsiyad and
Jozzey
Cruikshanks
added a commit
that referenced
this pull request
Jun 17, 2024
https://eaflood.atlassian.net/browse/WATER-4283 > Part of the work to replace NALD for handling return requirements In [Complete Select existing return requirement page](#895) we added the controls and logic to enable a user to copy the return requirements from an existing return version into the session. The H1 title we used though was though to be wrong. So, we [Correct copy existing return req. page title](#1092). When we did that, we also updated the validation message as all our current messages just replay the H1 title. Again however, this was thought to be incorrect. Our UAT team have decided the message we should show when an option is not selected is **Select a previous requirements for returns**. This is that change.
Cruikshanks
added a commit
that referenced
this pull request
Jun 18, 2024
https://eaflood.atlassian.net/browse/WATER-4283 > Part of the work to replace NALD for handling return requirements In [Complete Select existing return requirement page](#895) we added the controls and logic to enable a user to copy the return requirements from an existing return version into the session. The H1 title we used though was though to be wrong. So, we [Correct copy existing return req. page title](#1092). When we did that, we also updated the validation message as all our current messages just replay the H1 title. Again, however, this was thought to be incorrect. Our UAT team has decided the message we should show when an option is not selected is **Select a previous requirements for returns**. This is that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4283
We want to be able to offer users the option to copy data from an existing return requirement when setting up a new one. We made the option available in the
/setuppage.We then did the actual work of allowing users to select the return requirements to copy and saving them to the session in Complete Select existing return requirement page.
But we've since learned that the title we used for the page is not right. This change corrects it.