Returns required - Setup page (3 of 7) #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added setup page for return requirements journey. Step 3 of 7.
…quired-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
Demwunz
requested review from
robertparkinson and
Cruikshanks
and removed request for
robertparkinson
Demwunz
force-pushed
the
WATER-4267-returns-required-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
branch
from
f9b0ebe to
c4f44e6
Compare
robertparkinson
requested changes
Feb 15, 2024
| 'use strict' | ||
|
|
||
| /** | ||
| * Orchestrates fetching and presenting the data for `/return-requirements/{sessionId}/reason` page |
There was a problem hiding this comment.
should this be /setup rather than /reason ?
and the line below should be SetupService or something similar?
|
|
||
| /** | ||
| * Orchestrates validating the data for `/return-requirements/{sessionId}/setup` page | ||
| * @module SetupService |
There was a problem hiding this comment.
should the the other file be SetupService and this one SubmitSetupService ?
Comments were not complete, so had to amend them as per Roberts feedback
Demwunz
force-pushed
the
WATER-4267-returns-required-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
branch
from
76727aa to
cd2bc2c
Compare
Demwunz
changed the title
Demwunz
changed the title
…ou-want-to-set-up-page-iteration-2-3-of-7
robertparkinson
approved these changes
Feb 16, 2024
Demwunz
deleted the
WATER-4267-returns-required-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
branch
Demwunz
restored the
WATER-4267-returns-required-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setup page for return requirements journey. Step 3 of 7.
This page adds two radio controls to the page and has simple validation to ensure a value is selected.