fix(app): amend back link

DEFRA · Feb 15, 2024 · c4f44e6 · c4f44e6
1 parent 1316424
commit c4f44e6
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/app/validators/return-requirements/setup.validator.js b/app/validators/return-requirements/setup.validator.js
@@ -23,7 +23,7 @@ const VALID_VALUES = [
 function go (data) {
   const errorMessage = 'Select how you want to set up the return requirement'
   const schema = Joi.object({
-    reason: Joi.string()
+    setup: Joi.string()
       .required()
       .valid(...VALID_VALUES)
       .messages({

diff --git a/app/views/return-requirements/setup.njk b/app/views/return-requirements/setup.njk
@@ -11,7 +11,7 @@
   {{
     govukBackLink({
       text: 'Back',
-      href: '/system/return-requirements/' + id + '/reason'
+      href: rootLink + '/reason'
     })
   }}
 {% endblock %}
@@ -32,7 +32,7 @@
   <div class="govuk-body">
     <form method="post">
       {{ govukRadios({
-        name: "reason",
+        name: "setup",
         errorMessage: error,
         fieldset: {
           legend: {

diff --git a/test/services/return-requirements/submit-setup.service.test.js b/test/services/return-requirements/submit-setup.service.test.js
@@ -40,7 +40,7 @@ describe('Submit Setup service', () => {
     describe('with a valid payload', () => {
       beforeEach(() => {
         payload = {
-          reason: 'use_abstraction_data'
+          setup: 'use_abstraction_data'
         }
       })
 

diff --git a/test/validators/no-returns-required/setup.validator.test.js b/test/validators/no-returns-required/setup.validator.test.js
@@ -10,30 +10,30 @@ const { expect } = Code
 // Thing under test
 const SetupValidator = require('../../../app/validators/return-requirements/setup.validator.js')
 
-describe('Reason validator', () => {
+describe.only('Setup validator', () => {
   describe('when valid data is provided', () => {
     it('confirms the data is valid', () => {
-      const result = SetupValidator.go({ reason: 'use_abstraction_data' })
+      const result = SetupValidator.go({ setup: 'use_abstraction_data' })
 
       expect(result.value).to.exist()
       expect(result.error).not.to.exist()
     })
   })
 
   describe('when valid data is provided', () => {
-    describe("because no 'reason' is given", () => {
+    describe("because no 'setup' is given", () => {
       it('fails validation', () => {
-        const result = SetupValidator.go({ reason: '' })
+        const result = SetupValidator.go({ setup: '' })
 
         expect(result.value).to.exist()
         expect(result.error).to.exist()
         expect(result.error.details[0].message).to.equal('Select how you want to set up the return requirement')
       })
     })
 
-    describe("because an unknown 'reason' is given", () => {
+    describe("because an unknown 'setup' is given", () => {
       it('fails validation', () => {
-        const result = SetupValidator.go({ reason: 'just-because' })
+        const result = SetupValidator.go({ setup: 'just-because' })
 
         expect(result.value).to.exist()
         expect(result.error).to.exist()