Add new view bill service #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4155 We are building our first proper page which will replace the bill summary page the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui) currently provides. Rather than try to show all licences _and_ all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence. We've already made several other changes to support this. This change adds a new service that orchestrates fetching the information needed (see [Add new fetch billing account service](#493) and [Add new fetch bill service](#495)), passing it through to a presenter ([Add new Multi-licence bill presenter](#496)) and returning the result.
Cruikshanks
force-pushed
the
add-new-view-bill-service
branch
from
0821b8e to
fb9dcc6
Compare
Cruikshanks
added a commit
that referenced
this pull request
Nov 3, 2023
https://eaflood.atlassian.net/browse/WATER-4155 We are building our first proper page which will replace the bill summary page the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui) currently provides. Rather than try to show all licences _and_ all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence. We've already made several other changes to support this. With the addition of [Add new view bill service](#498) we can make the final change; creating the endpoint and adding the view template.
Cruikshanks
added a commit
that referenced
this pull request
Nov 3, 2023
https://eaflood.atlassian.net/browse/WATER-4155 We are building our first proper page which will replace the bill summary page the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui) currently provides. Rather than try to show all licences _and_ all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence. We've already made several other changes to support this. With the addition of [Add new view bill service](#498) we can make the final change; creating the endpoint and adding the view template.
Cruikshanks
added a commit
that referenced
this pull request
Nov 3, 2023
https://eaflood.atlassian.net/browse/WATER-4155 We are building our first proper page which will replace the bill summary page the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui) currently provides. Rather than try to show all licences _and_ all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence. We've already made several other changes to support this. With the addition of [Add new view bill service](#498) we can make the final change; creating the endpoint and adding the view template. --- Our first 'proper' template! The intent in the future is that all presentation code should reside in the template. So, unless necessary we should never see HTML or Nunjucks within our regular app code. But likewise, the logic in our templates should only be about generating the layout, not the content. So, `if` statements to see if something should be displayed, string concatenation to build links, or `for thing of things` to feed GOV.UK elements are fine. Code to format a value however should be in a presenter. Note - the SCSS content is styles that don't appear to exist in GOV.UK frontend package but do (in one version or another) exist in the prototype, the legacy UI, or both! We needed to add them to get the UI to match the prototype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4155
We are building our first proper page which will replace the bill summary page the water-abstraction-ui currently provides. Rather than try to show all licences and all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence.
We've already made several other changes to support this. This change adds a new service that orchestrates fetching the information needed (see Add new fetch billing account service and Add new fetch bill service), passing it through to a presenter (Add new Multi-licence bill presenter) and returning the result.