Add new Multi-licence bill presenter #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4155 We are building our first proper page which will replace the bill summary page the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui) currently provides. Rather than try to show all licences _and_ all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence. We've already made several other changes to support this. This change adds a new presenter which takes details of the bill summaries for the multiple licences linked to it and formats them ready for use in a new view bill page.
Dropped in because we realised we were missing grabbing the salutation for the contact. But then also spotted that the columns in our selects were not alphabetical (we still keep ID as the first though).
Cruikshanks
added a commit
that referenced
this pull request
Nov 3, 2023
https://eaflood.atlassian.net/browse/WATER-4155 We are building our first proper page which will replace the bill summary page the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui) currently provides. Rather than try to show all licences _and_ all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence. We've already made several other changes to support this. This change adds a new service that orchestrates fetching the information needed (see [Add new fetch billing account service](#493) and [Add new fetch bill service](#495)), passing it through to a presenter ([Add new Multi-licence bill presenter](#496)) and returning the result.
Co-authored-by: Jason Claxton <[email protected]>
Cruikshanks
added a commit
that referenced
this pull request
Nov 3, 2023
https://eaflood.atlassian.net/browse/WATER-4155 We are building our first proper page which will replace the bill summary page the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui) currently provides. Rather than try to show all licences _and_ all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence. We've already made several other changes to support this. This change adds a new service that orchestrates fetching the information needed (see [Add new fetch billing account service](#493) and [Add new fetch bill service](#495)), passing it through to a presenter ([Add new Multi-licence bill presenter](#496)) and returning the result.
Cruikshanks
added a commit
that referenced
this pull request
Nov 3, 2023
https://eaflood.atlassian.net/browse/WATER-4155 We are building our first proper page which will replace the bill summary page the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui) currently provides. Rather than try to show all licences _and_ all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence. We've already made several other changes to support this. This change adds a new service that orchestrates fetching the information needed (see [Add new fetch billing account service](#493) and [Add new fetch bill service](#495)), passing it through to a presenter ([Add new Multi-licence bill presenter](#496)) and returning the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4155
We are building our first proper page which will replace the bill summary page the water-abstraction-ui currently provides. Rather than try to show all licences and all their transactions for a bill on one page we'll instead list the licences. Users can then see the transaction details by selecting a licence.
We've already made several other changes to support this. This change adds a new presenter which takes details of the bill summaries for the multiple licences linked to it and formats them ready for use in a new view bill page.
We also spotted that we had missed a key field in our
FetchBillingAccountServiceso rectified that in this change.