Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRM_V2 address model #378

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Add CRM_V2 address model #378

merged 2 commits into from
Aug 25, 2023

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/WATER-4092

We are building a new endpoint to handle changing the address for a billing account.

We'll get into why we need to build a new endpoint when we start adding the code for it. But there are a series of changes we need to make in preparation.

The first of these was Add automatic payload cleaning. The next set of changes is adding the models we'll need to interact with the crm_v2 schema.

https://eaflood.atlassian.net/browse/WATER-4092

We are building a new endpoint to handle changing the address for a billing account.

We'll get into why we need to build a new endpoint when we start adding the code for it. But there are a series of changes we need to make in preparation.

The first of these was [Add automatic payload cleaning](#375). The next set of changes is adding the models we'll need to interact with the `crm_v2` schema.
@Cruikshanks Cruikshanks added the enhancement New feature or request label Aug 25, 2023
@Cruikshanks Cruikshanks self-assigned this Aug 25, 2023
@Cruikshanks Cruikshanks marked this pull request as ready for review August 25, 2023 07:37
@Cruikshanks Cruikshanks requested review from Jozzey and StuAA78 August 25, 2023 07:37
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cruikshanks Cruikshanks merged commit 4acf8de into main Aug 25, 2023
@Cruikshanks Cruikshanks deleted the add-crm-v2-address-model branch August 25, 2023 12:25
Cruikshanks added a commit that referenced this pull request Aug 25, 2023
https://eaflood.atlassian.net/browse/WATER-4092

In the following PR's we added some new models for the `crm_v2` schema

- [Add CRM_V2 address model](#378)
- [Add CRM_V2 contact model](#379)
- [Add CRM_V2 company model](#380)
- [Add CRM_V2 invoice account address model](#381)

To keep the changes to a minimum we omitted the relationships between them and the existing `InvoiceAccountModel`. This change adds those relationships in.
Cruikshanks added a commit that referenced this pull request Aug 29, 2023
https://eaflood.atlassian.net/browse/WATER-4092

In the following PRs we added some new models for the `crm_v2` schema

- [Add CRM_V2 address model](#378)
- [Add CRM_V2 contact model](#379)
- [Add CRM_V2 company model](#380)
- [Add CRM_V2 invoice account address model](#381)

To keep the changes to a minimum we omitted the relationships between them and the existing `InvoiceAccountModel`. This change adds those relationships in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants