Fix reissuing ALCS invoice bug

app/services/billing/supplementary/fetch-invoices-to-be-reissued.service.js

@@ -8,7 +8,7 @@
 const BillingInvoiceModel = require('../../../models/water/billing-invoice.model.js')
 
 /**
- * Takes a region and fetches billing invoices in that region marked for reissuing, along with their transactions
+ * Takes a region and fetches sroc billing invoices in that region marked for reissuing, along with their transactions
  *
  * @param {String} regionId The uuid of the region
  *
@@ -28,6 +28,7 @@ async function go (regionId) {
       .where('isFlaggedForRebilling', true)
       .joinRelated('billingBatch')
       .where('billingBatch.regionId', regionId)
+      .where('billingBatch.scheme', 'sroc')
       .withGraphFetched('billingInvoiceLicences.billingTransactions')
       .modifyGraph('billingInvoiceLicences', (builder) => {
         builder.select(

test/services/billing/supplementary/fetch-invoices-to-be-reissued.service.test.js

@@ -22,6 +22,7 @@ const FetchInvoicesToBeReissuedService = require('../../../../app/services/billi
 describe('Fetch Invoices To Be Reissued service', () => {
   let billingBatch
   let billingInvoice
+  let alcsBillingInvoice
 
   beforeEach(async () => {
     await DatabaseHelper.clean()
@@ -30,6 +31,15 @@ describe('Fetch Invoices To Be Reissued service', () => {
     billingInvoice = await BillingInvoiceHelper.add({ billingBatchId: billingBatch.billingBatchId })
     const { billingInvoiceLicenceId } = await BillingInvoiceLicenceHelper.add({ billingInvoiceId: billingInvoice.billingInvoiceId })
     await BillingTransactionHelper.add({ billingInvoiceLicenceId })
+
+    // Set up a separate billing batch which we will manually patch to be alcs
+    const alcsBillingBatch = await BillingBatchHelper.add()
+    alcsBillingInvoice = await BillingInvoiceHelper.add({ billingBatchId: alcsBillingBatch.billingBatchId })
+    const { billingInvoiceLicenceId: alcsBillingInvoiceLicenceId } = await BillingInvoiceLicenceHelper.add({
+      billingInvoiceId: alcsBillingInvoice.billingInvoiceId
+    })
+    await BillingTransactionHelper.add({ billingInvoiceLicenceId: alcsBillingInvoiceLicenceId })
+    await alcsBillingBatch.$query().patch({ scheme: 'alcs' })
   })
 
   describe('when there are no billing invoices to be reissued', () => {
@@ -81,6 +91,19 @@ describe('Fetch Invoices To Be Reissued service', () => {
         'billingTransactions'
       ])
     })
+
+    describe('and there are alcs billing invoices to be reissued', () => {
+      beforeEach(async () => {
+        await alcsBillingInvoice.$query().patch({ isFlaggedForRebilling: true })
+      })
+
+      it('returns only sroc billing invoices', async () => {
+        const result = await FetchInvoicesToBeReissuedService.go(billingBatch.regionId)
+
+        expect(result).to.have.length(1)
+        expect(result[0].billingInvoiceId).to.equal(billingInvoice.billingInvoiceId)
+      })
+    })
   })
 
   describe('when fetching from the db fails', () => {