Fix reissuing ALCS invoice bug #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4036 Reissuing was confirmed working in our local environments but was continuing to fail in `dev`. When we checked the logs we realised that it was failing because it was fetching alcs invoices that were awaiting reissuing as well as sroc ones! This then causes an error to come back from the CM as it won't reissue an alcs invoice onto an sroc bill run. We resolve this by updating `FetchInvoicesToBeReissuedService` to only fetch invoices linked to an sroc billing batch.
StuAA78
changed the title
Jozzey
requested changes
Jul 19, 2023
test/services/billing/supplementary/fetch-invoices-to-be-reissued.service.test.js
Outdated
Show resolved
Hide resolved
A comment during peer review made us realise we don't need to create the alcs billing batch for all tests, just the one where we're specifically testing that we don't retrieve alcs invoices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4036
Reissuing was confirmed working in our local environments but was continuing to fail in
dev. When we checked the logs we realised that it was failing because it was fetching alcs invoices that were awaiting reissuing as well as sroc ones! This then causes an error to come back from the CM as it won't reissue an alcs invoice onto an sroc bill run.We resolve this by updating
FetchInvoicesToBeReissuedServiceto only fetch invoices linked to an sroc billing batch.