Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import licence document roles for a licence - licence holder #1424

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

jonathangoulding
Copy link
Collaborator

https://eaflood.atlassian.net/browse/WATER-4717

We need to replace the import service logic to import a licence from NALD.

WRLS has the concept of a licence document. NALD does not.

As part of the import process a licence document is created from the NALD licence.

There are two roles we want to import returnsTo and licence holder.

This change will focus on the licence holder licence role.

We will insert this imported data in the relevant public views.

Previous work to set handle import was done for the returnTo role here - #1414

https://eaflood.atlassian.net/browse/WATER-4717

We need to replace the import service logic to import a licence from NALD.

WRLS has the concept of a licence document. NALD does not.

As part of the import process a licence document is created from the NALD licence.

There are two roles we want to import returnsTo and licence holder.

This change will focus on the licence holder licence role.

We will insert this imported data in the relevant public views.

Previous work to set handle import was done for the returnTo role here - #1414
@jonathangoulding jonathangoulding added the enhancement New feature or request label Oct 18, 2024
@jonathangoulding jonathangoulding self-assigned this Oct 18, 2024
@Cruikshanks Cruikshanks self-requested a review October 18, 2024 12:34
Cruikshanks
Cruikshanks previously approved these changes Oct 18, 2024
@jonathangoulding jonathangoulding marked this pull request as draft October 18, 2024 15:16
@jonathangoulding
Copy link
Collaborator Author

This is not ready.

The issue i have left to solve is:

Each licence version with a an issue should be imported.

A licence version with multiple increments and the same issue number should be imported. 

However if that increment has the same start date as another increment on the same issue. Then the end date of the oldest should be used.

@jonathangoulding jonathangoulding marked this pull request as ready for review October 28, 2024 15:35
@jonathangoulding
Copy link
Collaborator Author

This is not ready.

The issue i have left to solve is:

Each licence version with a an issue should be imported.

A licence version with multiple increments and the same issue number should be imported. 

However if that increment has the same start date as another increment on the same issue. Then the end date of the oldest should be used.

This has been fixed.

@jonathangoulding jonathangoulding merged commit 9e2b420 into main Oct 29, 2024
5 of 6 checks passed
@jonathangoulding jonathangoulding deleted the import-licence-document-role-licence-holder branch October 29, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants