-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import licence document roles for a licence #1414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4717 We need to replace the import service logic to import a licence from NALD. WRLS has the concept of a licence document. NALD does not. As part of the import process a licence document is created from the NALD licence. There are two roles we want to import returnsTo and licence holder. This change will focus on the returnsTo licence role. We will insert this imported data in the relevant public views.
jonathangoulding
force-pushed
the
import-licence-document-role-returns
branch
from
October 16, 2024 14:41
be85b08
to
27fd606
Compare
Cruikshanks
approved these changes
Oct 18, 2024
jonathangoulding
added a commit
that referenced
this pull request
Oct 18, 2024
https://eaflood.atlassian.net/browse/WATER-4717 We need to replace the import service logic to import a licence from NALD. WRLS has the concept of a licence document. NALD does not. As part of the import process a licence document is created from the NALD licence. There are two roles we want to import returnsTo and licence holder. This change will focus on the licence holder licence role. We will insert this imported data in the relevant public views. Previous work to set handle import was done for the returnTo role here - #1414
jonathangoulding
added a commit
that referenced
this pull request
Oct 29, 2024
* Import licence document roles for a licence - licence holder https://eaflood.atlassian.net/browse/WATER-4717 We need to replace the import service logic to import a licence from NALD. WRLS has the concept of a licence document. NALD does not. As part of the import process a licence document is created from the NALD licence. There are two roles we want to import returnsTo and licence holder. This change will focus on the licence holder licence role. We will insert this imported data in the relevant public views. Previous work to set handle import was done for the returnTo role here - #1414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4717
We need to replace the import service logic to import a licence from NALD.
WRLS has the concept of a licence document. NALD does not.
As part of the import process a licence document is created from the NALD licence.
There are two roles we want to import returnsTo and licence holder.
This change will focus on the returnsTo licence role.
We will insert this imported data in the relevant public views.