Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import licence document roles for a licence #1414

Merged
merged 25 commits into from
Oct 18, 2024

Conversation

jonathangoulding
Copy link
Collaborator

https://eaflood.atlassian.net/browse/WATER-4717

We need to replace the import service logic to import a licence from NALD.

WRLS has the concept of a licence document. NALD does not.

As part of the import process a licence document is created from the NALD licence.

There are two roles we want to import returnsTo and licence holder.

This change will focus on the returnsTo licence role.

We will insert this imported data in the relevant public views.

@jonathangoulding jonathangoulding self-assigned this Oct 16, 2024
@jonathangoulding jonathangoulding added the enhancement New feature or request label Oct 16, 2024
https://eaflood.atlassian.net/browse/WATER-4717

We need to replace the import service logic to import a licence from NALD.

WRLS has the concept of a licence document. NALD does not.

As part of the import process a licence document is created from the NALD licence.

There are two roles we want to import returnsTo and licence holder.

This change will focus on the returnsTo licence role.

We will insert this imported data in the relevant public views.
@jonathangoulding jonathangoulding force-pushed the import-licence-document-role-returns branch from be85b08 to 27fd606 Compare October 16, 2024 14:41
@jonathangoulding jonathangoulding marked this pull request as ready for review October 17, 2024 12:53
@jonathangoulding jonathangoulding marked this pull request as draft October 17, 2024 13:03
@jonathangoulding jonathangoulding marked this pull request as ready for review October 17, 2024 13:04
@jonathangoulding jonathangoulding removed the request for review from Cruikshanks October 17, 2024 13:12
@jonathangoulding jonathangoulding merged commit 8944e84 into main Oct 18, 2024
6 checks passed
@jonathangoulding jonathangoulding deleted the import-licence-document-role-returns branch October 18, 2024 09:17
jonathangoulding added a commit that referenced this pull request Oct 18, 2024
https://eaflood.atlassian.net/browse/WATER-4717

We need to replace the import service logic to import a licence from NALD.

WRLS has the concept of a licence document. NALD does not.

As part of the import process a licence document is created from the NALD licence.

There are two roles we want to import returnsTo and licence holder.

This change will focus on the licence holder licence role.

We will insert this imported data in the relevant public views.

Previous work to set handle import was done for the returnTo role here - #1414
jonathangoulding added a commit that referenced this pull request Oct 29, 2024
* Import licence document roles for a licence - licence holder

https://eaflood.atlassian.net/browse/WATER-4717

We need to replace the import service logic to import a licence from NALD.

WRLS has the concept of a licence document. NALD does not.

As part of the import process a licence document is created from the NALD licence.

There are two roles we want to import returnsTo and licence holder.

This change will focus on the licence holder licence role.

We will insert this imported data in the relevant public views.

Previous work to set handle import was done for the returnTo role here - #1414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants