-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mod Log model #1264
Merged
Merged
Add Mod Log model #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4563 https://eaflood.atlassian.net/browse/WATER-4564 https://eaflood.atlassian.net/browse/WATER-4565 > Part of the work to display a licence's history to users (mod log) Now we have a table to hold the imported NALD mod log records we need a model to access it, and relationships to access the mod logs from charge, licence, and return versions. Once added and linked we can then complete our work to expose this information, for example. - [Build new licence history page](#1182) - [Update view return version to include mod log info](#1261)
Cruikshanks
added a commit
that referenced
this pull request
Sep 5, 2024
https://eaflood.atlassian.net/browse/WATER-4645 https://eaflood.atlassian.net/browse/WATER-4635 We recently added 2 new models connected to two new tables to support managing return requirements and viewing licence history. - [Add Licence Version Purpose Point model](#1288) - [Add Mod Log model](#1264) When we did though we forgot to make them available to the acceptance test loader!
Cruikshanks
added a commit
that referenced
this pull request
Sep 5, 2024
https://eaflood.atlassian.net/browse/WATER-4645 https://eaflood.atlassian.net/browse/WATER-4635 We recently added two new models connected to two new tables to support managing return requirements and viewing licence history. - [Add Licence Version Purpose Point model](#1288) - [Add Mod Log model](#1264) When we did, though, we forgot to make them available to the acceptance test loader! Plus, as we are adding them to the test loader, we also need to ensure they are included in the teardown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4563
https://eaflood.atlassian.net/browse/WATER-4564
https://eaflood.atlassian.net/browse/WATER-4565
Now that we have a table to hold the imported NALD mod log records, we need a model to access it and relationships to access the mod logs from charge, licence, and return versions.
Once added and linked, we can complete our work to expose this information, for example.