Build new licence history page #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4566 Billing & Data rely on the NALD ‘mod log’ to be able to see that all 3 legs are in sync when managing a licence. For example, when a licence is varied (a new licence version is created), new charge and return versions are also created (if applicable). This PR is focused on building a new 'History' page to replicate ‘mod log’ within our system. It should display all licence, charge and return versions for the licence in a single table (no pagination), ordered by created date in descending order.
…EFRA/water-abstraction-system into build-new-licence-history-page
… and order by createdAt and version numbers
…EFRA/water-abstraction-system into build-new-licence-history-page
…licence and return versions
…EFRA/water-abstraction-system into build-new-licence-history-page
This makes it more consistent with the other controllers. Co-authored-by: Roble <[email protected]> 50 chars is here ->
We have updated the pageTitle to include the licence reference. However, we don't want to repeat that in the main H1. So, we can now just hard code the H1 as `History`. Co-authored-by: Roble <[email protected]>
Decided that the licence instance returned is sufficient for passing as is to the presenter which can then extract the properties it needs. Co-authored-by: Roble <[email protected]>
Split the work of dealing with the different version types into their own methods. They can then deal with the differences as opposed to using generic methods that are only needed for certain version types. Co-authored-by: Roble <[email protected]>
Co-authored-by: Roble <[email protected]>
Cruikshanks
added a commit
that referenced
this pull request
Aug 29, 2024
https://eaflood.atlassian.net/browse/WATER-4566 > Part of the work to display NALD mod log records as history in WRLS We recently added a new `history()` modifier to the charge, licence, and return version models that allows us to pull through mod log, and in some cases user details when querying for a record. We then call `$` instance methods to determine, who created a record or what the reason was. We're making use of it in [Build new licence history page](#1182) but that change has highlighted to make `$createdAt()` work we have to ensure we include `createdAt` in the parent query's `select()`. This should really be dealt with in the `history()` modifier. This change makes it so!
Cruikshanks
added a commit
that referenced
this pull request
Aug 29, 2024
https://eaflood.atlassian.net/browse/WATER-4566 > Part of the work to display NALD mod log records as history in WRLS We recently added a new `history()` modifier to the charge, licence, and return version models that allows us to pull through the mod log and, in some cases, user details when querying for a record. We then call `$` instance methods to determine who created a record or what the reason was. We're using it in [Build new licence history page](#1182), but that change has highlighted that to make `$createdAt()` work, we have to ensure we include `createdAt` in the parent query's `select()`. This should be dealt with in the `history()` modifier. This change makes it so!
…EFRA/water-abstraction-system into build-new-licence-history-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4566
Billing & Data rely on the NALD ‘mod log’ to be able to see that all 3 legs are in sync when managing a licence. For example, when a licence is varied (a new licence version is created), new charge and return versions are also created (if applicable).
This PR is focused on building a new 'History' page to replicate ‘mod log’ within our system. It should display all licence, charge and return versions for the licence in a single table (no pagination), ordered by created date in descending order.