Spike building a licence history page #1167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4541 We've started talking the NALD 'mod log'. Our current understanding is that whenever a user creates a new return, licence or charge version NALD pops up an 'event' where the user is expected to enter a reason and a note. Essentially, why the change is being made. They then have reports that combine these events. They use these to ensure the 3 legs of water abstraction are in sync. (They often use the metaphor of a stool, with licence (abs), returns and charging the 3 legs). When viewed as a report, this essentially just seems to be what other systems would call history i.e. the history of changes to a licence. There is a concern that moving away from the NALD also means losing the 'mod log' and therefore how would they ensure things are in sync. This 'spike' is to build an example licence history page that combines licence, return and charge versions into one place to see if any of these concerns can be alleviated.
Sort by date desc. Where two entries have the same date then go by order of type - return version - charge version - licence version We read the history from latest (top) to earliest (bottom). Where we have matching dates we go with an assumed order for version entry; licence then charge then return version.
After a quick consult with our designer agreed it would be better to split the notes from the return version and the mod log rather than merge them into a single note.
We now have a table so this is redundant. Will update properly later
|
This has served its purpose. We now have #1182 approved and ready to be merged. So, bye-bye spike! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4541
We've started talking about the NALD 'mod log'. Our current understanding is that whenever a user creates a new return, licence, or charge version NALD pops up an 'event' where the user is expected to enter a reason and a note. Essentially, why the change is being made.
They then have reports that combine these events. They use these to ensure the 3 legs of water abstraction are in sync. (They often use the metaphor of a stool, with licence (abs), returns and charging the 3 legs).
When viewed as a report, this essentially just seems to be what other systems would call history i.e. the history of changes to a licence.
There is a concern that moving away from the NALD also means losing the 'mod log' and therefore how would they ensure things are in sync.
This 'spike' is to build an example licence history page that combines licence, return and charge versions into one place to see if any of these concerns can be alleviated.