Add the returns cycle text to the returns requirements check page #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add returns cycles to the return requirement summary card. As of this commit there is only 'summer' and 'winter and all year' returns cycles Previous work done here - #1019
|
Not sure why sonar is saying the if condition is not tested for the winter all year. But it is tested in the presenter tests |
Cruikshanks
requested changes
Jun 5, 2024
app/presenters/return-requirements/check/returns-requirements.presenter.js
Outdated
Show resolved
Hide resolved
test/presenters/return-requirements/check/returns-requirements.presenter.test.js
Outdated
Show resolved
Hide resolved
…presenter.js Co-authored-by: Alan Cruikshanks <[email protected]>
….presenter.test.js Co-authored-by: Alan Cruikshanks <[email protected]>
assume that if the return is not summer it is winter as there are only two options
Cruikshanks
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work.
https://eaflood.atlassian.net/browse/WATER-4386
This branch will add returns cycles to the return requirement summary card. As of this commit there is only 'summer' and 'winter and all year' returns cycles
Previous work done here - #1019