Check your requirements page (with requirements summary cards) #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments summary cards) https://eaflood.atlassian.net/browse/WATER-4386 This branch will add summary cards to the `check` page in the returns journey to display the customer's requirements. Each box will reflect the requirements details (item, quantity etc) and link to the relevant requirement page. This will provide a quick overview for the user on the `check` page.
…ur-requirements-page-with-requirements-summary-cards
…ur-requirements-page-with-requirements-summary-cards
…ur-requirements-page-with-requirements-summary-cards
Cruikshanks
reviewed
May 21, 2024
…ur-requirements-page-with-requirements-summary-cards
…ur-requirements-page-with-requirements-summary-cards
Demwunz
force-pushed
the
WATER-4386-returns-required-journey-check-your-requirements-page-with-requirements-summary-cards
branch
from
911d950 to
18867cc
Compare
Cruikshanks
previously requested changes
May 23, 2024
Alpha function order Alpha object order
robertparkinson
previously approved these changes
May 30, 2024
jonathangoulding
force-pushed
the
WATER-4386-returns-required-journey-check-your-requirements-page-with-requirements-summary-cards
branch
from
3905468 to
d6fe389
Compare
…ur-requirements-page-with-requirements-summary-cards
robertparkinson
previously approved these changes
May 30, 2024
…ur-requirements-page-with-requirements-summary-cards
…ur-requirements-page-with-requirements-summary-cards
|
I have pushed the changes for - #1019 (review) I have added a map function for the requirement to extract all fields needed for the view. I will work on the other requirment fields in the session object / view in another PR. It is assumed we need to do some fetch requests to get the information for the view (requirement.purposes) so it makes sense to do that in a separate PR. |
…ur-requirements-page-with-requirements-summary-cards
robertparkinson
approved these changes
May 31, 2024
…ur-requirements-page-with-requirements-summary-cards
…ur-requirements-page-with-requirements-summary-cards
jonathangoulding
deleted the
WATER-4386-returns-required-journey-check-your-requirements-page-with-requirements-summary-cards
branch
jonathangoulding
added a commit
that referenced
this pull request
May 31, 2024
Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add purposes to the return requirement summary card Previous work done here - #1019
jonathangoulding
added a commit
that referenced
this pull request
May 31, 2024
Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add purposes to the return requirement summary card Previous work done here - #1019
jonathangoulding
added a commit
that referenced
this pull request
Jun 4, 2024
Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add points to the return requirement summary card. Previous work done here - #1019
jonathangoulding
added a commit
that referenced
this pull request
Jun 4, 2024
* Check your requirements - purposes Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add purposes to the return requirement summary card Previous work done here - #1019
jonathangoulding
added a commit
that referenced
this pull request
Jun 4, 2024
Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add points to the return requirement summary card. Previous work done here - #1019
jonathangoulding
added a commit
that referenced
this pull request
Jun 5, 2024
* Feature returns required points Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add points to the return requirement summary card. Previous work done here - #1019
jonathangoulding
added a commit
that referenced
this pull request
Jun 5, 2024
Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add returns cycles to the return requirement summary card. As of this commit there is only 'summer' and 'winter and all year' returns cycles Previous work done here - #1019
jonathangoulding
added a commit
that referenced
this pull request
Jun 5, 2024
Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add agreement exceptions to the return requirement summary card. This will be a comma seperated list in the oxford comma style. Previous work done here - #1019
jonathangoulding
added a commit
that referenced
this pull request
Jun 5, 2024
) * Add the returns cycle text to the returns requirements check page Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add returns cycles to the return requirement summary card. As of this commit there is only 'summer' and 'winter and all year' returns cycles Previous work done here - #1019 * chore: pre pr fixes * fix: test failing missing returns cycle assert * chore: alpha order * Update app/presenters/return-requirements/check/returns-requirements.presenter.js Co-authored-by: Alan Cruikshanks <[email protected]> * Update test/presenters/return-requirements/check/returns-requirements.presenter.test.js Co-authored-by: Alan Cruikshanks <[email protected]> * fix: use ternary for returns cycle assume that if the return is not summer it is winter as there are only two options --------- Co-authored-by: Alan Cruikshanks <[email protected]>
jonathangoulding
added a commit
that referenced
this pull request
Jun 7, 2024
…age (#1076) * Add the agreement exceptions text to the returns requirements check page Due to the estimated complexity of adding fetch services for purposes, points and other display items. We have broken down the complex display items into their own branches of work. https://eaflood.atlassian.net/browse/WATER-4386 This branch will add agreement exceptions to the return requirement summary card. This will be a comma seperated list in the oxford comma style. Previous work done here - #1019 Co-authored-by: Alan Cruikshanks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4386
This branch will add summary cards to the
checkpage in the returns journey to display the customer's requirements.Each box will reflect the requirements details (item, quantity etc) and link to the relevant requirement page.
This will provide a quick overview for the user on the
checkpage.