Add return requirements models to project #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
force-pushed
the
add-return-requirement-models
branch
from
4d17bbe to
6712e1b
Compare
https://eaflood.atlassian.net/browse/WATER-4467 So far, the new returns requirements functionality supports setting up a new return version and its requirements. But the data is held only in a temporary session. Alongside this, we've been making changes to the legacy return requirements tables so they can support the new properties we will record in our version of the returns requirement setup journey. We now want to create new return requirements by copying an existing one, persist those that have been setup during the journey and in the future generate return logs using this information. All this will need the tables to be represented as [Objection.js models](https://vincit.github.io/objection.js/). This change adds the models, the views and all the supporting elements in preparation for this work.
Cruikshanks
force-pushed
the
add-return-requirement-models
branch
from
6712e1b to
27637ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4467
So far, the new returns requirements functionality supports setting up a new return version and its requirements. But the data is held only in a temporary session.
Alongside this, we've been making changes to the legacy return requirements tables so they can support the new properties we will record in our version of the returns requirement setup journey.
We now want to create new return requirements by copying an existing one, persist those that have been setup during the journey, and in the future, generate return logs using this information.
All this will require the tables to be represented as Objection.js models. This change adds the models, the views, and all the supporting elements in preparation for this work.