Add copy from existing returns #1056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertparkinson
changed the title
Beckyrose200
requested changes
May 31, 2024
app/services/return-requirements/fetch-return-requirements.service.js
Outdated
Show resolved
Hide resolved
app/services/return-requirements/fetch-return-requirements.service.js
Outdated
Show resolved
Hide resolved
app/services/return-requirements/fetch-return-requirements.service.js
Outdated
Show resolved
Hide resolved
Beckyrose200
requested changes
Jun 3, 2024
| @@ -5,23 +5,25 @@ | |||
| * @module SetupService | |||
| */ | |||
|
|
|||
| const FetchReturnRequirementsService = require('./fetch-return-requirements.service.js') | |||
| const SetupPresenter = require('../../presenters/return-requirements/setup.presenter.js') | |||
| const SessionModel = require('../../models/session.model.js') | |||
There was a problem hiding this comment.
Just a nit comment but these two need to be swapped round
const SessionModel = require('../../models/session.model.js')
const SetupPresenter = require('../../presenters/return-requirements/setup.presenter.js')
| // Thing under test | ||
| const ReturnRequirementModel = require('../../app/models/return-requirement.model.js') | ||
|
|
||
| describe('Return version model', () => { |
There was a problem hiding this comment.
Suggested change
| describe('Return version model', () => { | |
| describe('Return requirement model', () => { |
| 'use strict' | ||
|
|
||
| /** | ||
| * @module ReturnVersionHelper |
There was a problem hiding this comment.
Suggested change
| * @module ReturnVersionHelper | |
| * @module ReturnRequirementHelper |
| * | ||
| * @param {Object} [data] Any data you want to use instead of the defaults used here or in the database | ||
| * | ||
| * @returns {Promise<module:ReturnVersionModel>} The instance of the newly created record |
There was a problem hiding this comment.
Suggested change
| * @returns {Promise<module:ReturnVersionModel>} The instance of the newly created record | |
| * @returns {Promise<module:ReturnRequirementModel>} The instance of the newly created record |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4355
As part of our work to replace NALD for handing return requirements we want to be able to copy data from an existing returns. This PR adds the option to the "How do you want to set up the returns" page and checks to see if there is any existing returns for the current licence. If there is show the extra option.