0.8.1: PVS Studio flagged buffer underflows in the state reset functions #625
Comments
Cyan4973
added a commit
that referenced
this issue
Dec 1, 2021
PVS Studio static analyzer doesn't like that the structure is not entirely initialized. This was supposed to allow, in some future, to reduce the size of the state, while minimizing impact with library's installed based (in case of version mismatch). This is way too complex and risky for such a tiny benefit. So revert to the classical "init everything" method, which should please PVS Studio. The last member will remain "reserved" and unused. Who knows, maybe in some future, it may be of some use, for some purpose yet to determine.
Merged
Cyan4973
added a commit
that referenced
this issue
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My guess is it's detecting the use of the reserved portion, which if coming from malloc (for the memory behind the incoming state pointer), might contain garbage.
The text was updated successfully, but these errors were encountered: