Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an assert comparison the same values (flagged by PVS Studio in 0.8.1) #628

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fix an assert comparison the same values (flagged by PVS Studio in 0.8.1) #628

merged 1 commit into from
Dec 1, 2021

Conversation

kcgen
Copy link
Contributor

@kcgen kcgen commented Nov 30, 2021 •
edited
Loading

Cyan4973
Cyan4973 requested changes Nov 30, 2021
View reviewed changes
Copy link
Owner

@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the second issue nbStripesToEnd is fine in this PR.

I'll proceed differently for the other 2 issues.

@kcgen
Copy link
Contributor Author

kcgen commented Nov 30, 2021 •
edited
Loading

Only the second issue nbStripesToEnd is fine in this PR.

Thanks for the quick review. I've now dropped the other two commits.

I'll proceed differently for the other 2 issues.

Thanks for addressing these @Cyan4973.
Happy to re-run more PVS scans to help wrap these up.

@kcgen kcgen changed the title Address minor items flagged by PVS Studio in 0.8.1 Fix an assert comparison the same values (flagged by PVS Studio in 0.8.1) Nov 30, 2021
@kcgen kcgen requested a review from Cyan4973 November 30, 2021 19:56
@Cyan4973 Cyan4973 merged commit b624174 into Cyan4973:dev Dec 1, 2021
@kcgen kcgen deleted the kc/dev-0.8.1-pvs-fixes-1 branch December 1, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.8.1: PVS Studio flagged a copy and paste error asserting the same values
2 participants
@kcgen @Cyan4973