chore: remove Button's test helpers

[clintcs]

🚀 Description

I've been going through our components and adding test helpers so consumers don't have to select elements themselves, thereby digging into our implementation. It occurred to me while thinking about what needs test helpers and what doesn't that Button may not need any.

Because Button is more or less composed of one element (<button />) the consumer can spread an ID or data attribute onto Button and use that ID or data attribute to select that element. He can then use a combination of QUnit DOM and Ember Test Helpers to assert what needs asserting. No need, for example, to provide an abstraction for checking whether Button is disabled or for clicking it.

---

🔬 How to Test

If the build is green, we're good.

[changeset-bot]

🦋 Changeset detected

Latest commit: ce91639

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@crowdstrike/ember-toucan-core	Minor
@crowdstrike/ember-toucan-form	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Preview URLs

Env: preview
Docs: https://8609f6b5.ember-toucan-core.pages.dev

[clintcs]

@ynotdraw: Before I take this out of draft, add a description, and send it out for review, I thought I'd see how you feel. I'm working on adding test helpers to components that need them, but I'm wondering: does Button need them?

[clintcs]

This is the only test helper I was able to see a decent argument for. Is it something we need to test? Or does the [data-test-loading] assertion below sufficiently cover it?

[ynotdraw]

I feel as though the assertion below is sufficient enough probably

[ynotdraw]

I feel as though the assertion below is sufficient enough probably

[ynotdraw]

Before I take this out of draft, add a description, and send it out for review, I thought I'd see how you feel. I'm working on adding test helpers to components that need them, but I'm wondering: does Button need them?

Good question. I'm kind of thinking maybe these aren't super helpful? All of this stuff can be accomplished already with the built-in ember qunit assertions and/or with the built-in ember test helpers. I think components like our autocomplete and multi select are complicated enough that they warrant helpers; however, I'm not sure I feel the same with Button.

A bit tangential to this, but I also wonder if we should make Button more dumb eventually and not have those named blocks with styling. I feel as though they are implementation details that downstream/other consumers may not care about or want. And those states are something they can write themselves, rather than it being baked into the core Button. Nothing we need to do now, of course, but maybe something in the future to think about to make this less opinionated and force strong opinions upstream

[clintcs]

I think components like our autocomplete and multi select are complicated enough that they warrant helpers; however, I'm not sure I feel the same with Button.

Sounds good. I'll move ahead with this PR.

A bit tangential to this, but I also wonder if we should make Button more dumb eventually and not have those named blocks with styling.

🤔