fix: Add container to textarea to resolve style issues and add padding to input to match #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c18922f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview URLsEnv: preview |
ynotdraw
force-pushed
the
textarea-w-full-fix
branch
from
1c5af8f
to
c0a32ce
Compare
ynotdraw
commented
Aug 10, 2023
| @@ -44,14 +44,14 @@ export default class ToucanFormTextareaControlComponent extends Component<Toucan | |||
| } | |||
|
|
|||
| if (isReadOnly) { | |||
| return 'focus:shadow-focus-outline bg-surface-xl shadow-read-only-outline text-titles-and-attributes'; | |||
| return 'focus-within:shadow-focus-outline bg-surface-xl shadow-read-only-outline text-titles-and-attributes'; | |||
There was a problem hiding this comment.
Need to switch to focus-within due to using a container now
| @@ -158,7 +158,6 @@ export default class ToucanFormInputFieldComponent extends Component<ToucanFormI | |||
| field.errorId | |||
| }}" | |||
| aria-invalid={{if @error "true"}} | |||
| class="w-full" | |||
There was a problem hiding this comment.
Controls now specify w-full so this isn't needed anymore
| @@ -19,17 +19,17 @@ module('Integration | Component | Fields | Textarea', function (hooks) { | |||
| assert | |||
| .dom('[data-hint]') | |||
| .doesNotExist( | |||
| 'Expected hint block not to be displayed as a hint was not provided' | |||
| 'Expected hint block not to be displayed as a hint was not provided', | |||
There was a problem hiding this comment.
Apparently some post-prettier-v3-upgrade formatting that was missed 🤷
ynotdraw
force-pushed
the
textarea-w-full-fix
branch
2 times, most recently
from
e3fb4fd
to
a10f2f1
Compare
ynotdraw
commented
Aug 10, 2023
Comment on lines
+2
to
+4
| <div class='w-96'> | ||
| <Form::Controls::Input /> | ||
| </div> |
There was a problem hiding this comment.
Since these are now full-width by default, adding the container with the fixed width so they don't look ridiculous 😂
ynotdraw
commented
Aug 10, 2023
ynotdraw
changed the title
nicolechung
approved these changes
Aug 10, 2023
ynotdraw
force-pushed
the
textarea-w-full-fix
branch
from
a10f2f1
to
d707900
Compare
ynotdraw
force-pushed
the
textarea-w-full-fix
branch
from
d707900
to
c18922f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
inputpadding to match the designstextareaso that the drag handle and long text does not collide with the focus and focus+error shadows.inputas well (px-2). Autocomplete and Multiselect already had these classes specified, so now everything is consistent 🎉🔬 How to Test
0.5remviapx-2📸 Images/Videos of Functionality