Add MultiselectField component #225
Conversation
🦋 Changeset detectedLatest commit: 076d015 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview URLsEnv: preview |
There was a problem hiding this comment.
This was duplicated 🙈
There was a problem hiding this comment.
This is mostly copy / paste from our other Field docs, except updated to reflect the Multiselect Component API
There was a problem hiding this comment.
These were stragglers from the previous PR, where they were incorrect now since we added :remove
There was a problem hiding this comment.
A few updates from the previous PR where I didn't update to :default or some typos/incorrect information after re-reviewing.
There was a problem hiding this comment.
This should be pretty familiar - essentially copy paste from the other *Field components, only swapping out the underlying control to the Multiselect.
There was a problem hiding this comment.
Similar to above, this test is basically copy paste of *-field-test files, exercising only the necessities. Most of the complex testing of the mulitselect is handled in the control test, so this essentially just makes sure it wraps around a Field properly and exercises @selected and @onChange briefly.
|
Going to go ahead and merge to unblock @clintcs's work, but for the other reviewers - feel free to leave comments and I'll get them addressed in downstream PRs! Since we are protected by changesets, consumers can't actually use this code until we merge the release PR 🎉 |
🚀 Description
This PR adds
MultiselectFieldsupport /<Form::Fields::Multiselect.🔬 How to Test
📸 Images/Videos of Functionality
Screen.Recording.2023-07-21.at.9.10.57.AM.mov