-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#43: Upgrade to latest eslint-plugin-ember, remove eslint-disable, and make --fix work again #181
Conversation
|
Preview URLsEnv: preview |
@@ -1,16 +1,13 @@ | |||
/* eslint-disable no-undef -- Until https://github.com/ember-cli/eslint-plugin-ember/issues/1747 is resolved... */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can also get rid of this now due to glimmerjs/glimmer-vm#1406 being merged, but I'll test that out and put up a separate PR for those changes to keep these focused on the --fix
path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 😍
TIL about ember-cli/eslint-plugin-ember#1853, need to pull that into headless-forms as well!
…e --fix work again Compare to CrowdStrike/ember-toucan-core#181
…e --fix work again Compare to CrowdStrike/ember-toucan-core#181
…e --fix work again Compare to CrowdStrike/ember-toucan-core#181
🚀 Description
This PR upgrades us to the latest
eslint-plugin-ember
and removes theeslint-disable
comments in ourgts
files. Fixed via:With this change, you can now click the lightbulb in VS Code > Auto-fix all issues. Or via the CLI you can do
pnpm lint:js:fix
to resolve all eslint issues automatically.Closes #43
🔬 How to Test
📸 Images/Videos of Functionality
N/A