Fix type violations due to missing glint configuration #90
Conversation
|
There was a problem hiding this comment.
Thanks so much for looking into this!
CI shows some new issues though, any idea? https://github.com/CrowdStrike/ember-headless-form/actions/runs/4439238826/jobs/7791450494?pr=90#step:5:27
| @@ -33,7 +33,6 @@ | |||
| "@embroider/util": "^1.10.0", | |||
| "ember-async-data": "^0.7.0", | |||
| "ember-modifier": "^4.1.0", | |||
| "rollup-plugin-glimmer-template-tag": "^0.1.0", | |||
There was a problem hiding this comment.
Oups, that was a dependency? 🤦
| @@ -187,9 +188,11 @@ export default class HeadlessFormComponent< | |||
| DATA extends UserData, | |||
| SUBMISSION_VALUE | |||
| > extends Component<HeadlessFormComponentSignature<DATA, SUBMISSION_VALUE>> { | |||
| // we cannot use (modifier "on") directly in the template due to https://github.com/emberjs/ember.js/issues/19869 | |||
| on = on; | |||
There was a problem hiding this comment.
Oh, right. I was too eager to remove this 👍
| @@ -1,12 +1,13 @@ | |||
| import Component from '@glimmer/component'; | |||
| import { tracked } from '@glimmer/tracking'; | |||
| import { assert, warn } from '@ember/debug'; | |||
| import { hash } from '@ember/helper'; | |||
| // @ts-ignore hash is missing from ember types | |||
There was a problem hiding this comment.
But linting was happy with this file. IIRC modifier was actually missing, not? But somehow it was not needed, the template was still working for me locally without the import 🤔
There was a problem hiding this comment.
yeah, it's a built-in, but not yet for types -- I think there is an open issue about it and it came up in discord a couple days ago
potentially! it's possible something got messed up with this code: https://github.com/NullVoxPopuli/rollup-plugin-glimmer-template-tag/blob/main/packages/rollup-plugin-glimmer-template-tag/src/rollup-plugin.js#L90 -- it relies on the consumer's babel config to be able to parse correctly |
|
idk what's up with the lints (out of date dep, props?) |
|
Looks like: |
|
I'll merge this as-is, and try to fix the remaining issues in the main branch! |
Many of the type errors that I could see were due to missing the template-imports glint environment.
This has been added.