Update to Glint 1.0.0-beta.3 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLsEnv: preview |
simonihmig
force-pushed
the
update-glint
branch
from
1fa61de
to
5c51e1f
Compare
ynotdraw
approved these changes
Feb 24, 2023
| @@ -154,8 +149,7 @@ class FieldData< | |||
| export default class HeadlessFormComponent< | |||
| DATA extends UserData | |||
| > extends Component<HeadlessFormComponentSignature<DATA>> { | |||
| FieldComponent: ComponentLike<HeadlessFormFieldComponentSignature<DATA>> = | |||
| FieldComponent; | |||
| FieldComponent = FieldComponent<DATA>; | |||
Merged
nicolechung
approved these changes
Feb 27, 2023
nicolechung
reviewed
Feb 27, 2023
| TextareaComponent; | ||
| RadioComponent: ComponentLike<HeadlessFormControlRadioComponentSignature> = | ||
| RadioComponent; | ||
| LabelComponent = LabelComponent; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the docs uncovered more weird pnpm (peer) dependency issues, that I was able to fix by upgrading Glint to the latest beta. Also applies some fixes and removes previous workarounds related to typed-ember/glint#518.