Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall target as mentioned in #138 #305

Merged
merged 3 commits into from
Dec 19, 2021
Merged

Uninstall target as mentioned in #138 #305

merged 3 commits into from
Dec 19, 2021

Conversation

navidcity
Copy link
Contributor

The sample snippet in Uninstall target with Cmake is used without any modification.
It removes all the files created by install target using install_manifest.txt in build directory.
The drawback is that the uninstall target wont remove the directories.

@The-EDev The-EDev linked an issue Dec 18, 2021 that may be closed by this pull request
Copy link
Collaborator

@luca-schlecker luca-schlecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cmake_uninstall.cmake.in should be inside the cmake/ folder.
Looking good otherwise. Working the way it was intended with the known limitation of it not removing the then maybe empty crow folder.

Copy link
Collaborator

@luca-schlecker luca-schlecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. 👍

@luca-schlecker luca-schlecker merged commit f4785cd into CrowCpp:master Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible make uninstall rule for CMake?
2 participants