Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible make uninstall rule for CMake? #138

Closed
ayaankhan98 opened this issue May 28, 2021 · 4 comments · Fixed by #305
Closed

Possible make uninstall rule for CMake? #138

ayaankhan98 opened this issue May 28, 2021 · 4 comments · Fixed by #305
Labels
feature Code based project improvement good first issue an issue suitable to start contributing to the project

Comments

@ayaankhan98
Copy link
Contributor

In #80 CMake install rules were merged. Should we also support make unistall to remove those files (in case if required).
@The-EDev The-EDev added the feature Code based project improvement label May 28, 2021
@The-EDev
Copy link
Member

Sure, feel free to open a PR making the rule. Thanks!

@ayaankhan98
Copy link
Contributor Author

As far as i know, 🤔 CMake does not offer any direct feature to write unistall rules (Unlike the case of install rules). Therefore, we have to choose someother way to achieve this.

@The-EDev
Copy link
Member

The-EDev commented Jun 9, 2021

perhaps take a look at https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#can-i-do-make-uninstall-with-cmake

@ayaankhan98
Copy link
Contributor Author

perhaps take a look at https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#can-i-do-make-uninstall-with-cmake

Thanks 👍 , i had seen that earlier. I just mentioned that point because in case if someone else is going to take this issue then that information will help.

@The-EDev The-EDev added the good first issue an issue suitable to start contributing to the project label Oct 1, 2021
@The-EDev The-EDev linked a pull request Dec 18, 2021 that will close this issue
Uninstall target as mentioned in #138 #305
Merged
luca-schlecker added a commit that referenced this issue Dec 19, 2021
@luca-schlecker
Merge pull request #305 from navidcity/uninstall_target
f4785cd 
Uninstall target as mentioned in #138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Code based project improvement good first issue an issue suitable to start contributing to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uninstall target as mentioned in #138
2 participants
@ayaankhan98 @The-EDev