Replace dumb_timer_queue with new task_timer

[luca-schlecker]

Signed-off-by: Luca Schlecker [email protected]

It fixes #264 and lays the ground for #273 and #257.

This PR completely substitutes dumb_timer_queue for a new class named task_timer.
The advantages include:

• Ability to use a custom timeout for each task (function call)
• Doesn't use a static tick delay shared between all instances.
• Moved io_service logic into this class where it in my opinion should belong. (Moved from http_server.h)
• Unit test for task_timer

[The-EDev]

Functionally I don't see anything wrong. Though it might be a good idea to inline methods like get_default_timeout() or set_default_timeout().
Other than that I do have a couple things to point out. The first is that GCC gives a reorder warning when compiling, I'm guessing this is because of where timeout is placed in http_server.h.

The second is purely visual, and is about the comment style, since crow uses the following style (without the need for @brief):

/// Brief Description Here
///
/// Loooooong Description

And \ instead of @ for commands.

Lastly looking at this image:

\return might not work as you intended (I'm not 100% sure, it seems weird that the return type is there and there's a returns part). And there are a few places where a line break isn't showing (probably requires a <br>).

I'm sorry if any of the points are wrong or not explained well enough. Besides them the code seems quite good and running the tests and examples it seems to work as intended.

[luca-schlecker]

Isn't a member function with its body defined inside the class implicitly an inline function?
"A function defined entirely inside a class/struct/union definition, whether it's a member function or a non-member friend function, is implicitly an inline function." (cppreference.com)
It looks like in the screenshot of Doxygen you've sent, these functions are already classified as inline, supporting the above point.

I've seen that warning too, I'll look into it.

I'll change the comment style to align with Crow's style.

[The-EDev]

Everything seems good now. Great job!

P.S. If you want to force push your changes to get rid of the commits let me know, otherwise I guess we can merge this.

[luca-schlecker]

I think it should be fine. 🚀