Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps are not independent of each other due to dumb_timer_queue. #264

Closed
luca-schlecker opened this issue Nov 3, 2021 · 1 comment · Fixed by #278
Closed

Apps are not independent of each other due to dumb_timer_queue. #264

luca-schlecker opened this issue Nov 3, 2021 · 1 comment · Fixed by #278
Assignees
Labels
bug Something isn't working

Comments

@luca-schlecker
Copy link
Collaborator

dumb_timer_queue::tick is shared between all apps, leading them to influence each other.

class dumb_timer_queue
{
public:
static int tick;

Crow/include/crow/app.h

Lines 120 to 125 in 6f2eeda

///Set the connection timeout in seconds (default is 5)
self_t& timeout(std::uint8_t timeout)
{
detail::dumb_timer_queue::tick = timeout;
return *this;
}

dumb_timer_queue notably appears in the following files:

@luca-schlecker luca-schlecker self-assigned this Nov 3, 2021
@The-EDev The-EDev added the bug Something isn't working label Nov 3, 2021
@The-EDev
Copy link
Member

The-EDev commented Nov 8, 2021

I know this might be outside this issue, but modifying dumb_timer_queue::tick in a way that allows each function to have its own time would set the stage to solving #257.

luca-schlecker added a commit that referenced this issue Nov 19, 2021
fixes #264, lays ground for #273 and #257.

Signed-off-by: Luca Schlecker <[email protected]>
luca-schlecker added a commit that referenced this issue Nov 19, 2021
fixes #264, lays ground for #273 and #257.

Signed-off-by: Luca Schlecker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants