Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eval() to remove Torch warnings during testing #472

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Add eval() to remove Torch warnings during testing #472

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad6b3eb
Add eval() to remove warnings during Torch tests.
mellis13 Jan 31, 2024
ee54e29
Changelog
mellis13 Feb 1, 2024
e6fe000
Fix ordering.
mellis13 Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion doc/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ To be released at some future point in time

Description

- Updated tests to address Torch warning
- Updated GitHub actions to latest versions in CI/CD
- Dropped Cobalt support
- Override the sphinx-tabs extension background color
Expand All @@ -28,6 +29,8 @@ Description

Detailed Notes

- Tests that were saving Torch models were emitting warnings. These warnings
were addressed by updating the model save test function. (SmartSim-PR472_)
- Some actions in the current GitHub CI/CD workflows were outdated. They were
replaced with their latest versions. (SmartSim-PR446_)
- As the Cobalt workload manager is not used on any system we are aware of,
Expand All @@ -42,7 +45,7 @@ Detailed Notes
all of SmartSim's machine learning backends with Python 3.11.
(SmartSim-PR451_) (SmartSim-PR461_)


.. _SmartSim-PR472: https://github.com/CrayLabs/SmartSim/pull/472
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredibly minor detail, but its going to bug me if I don't mention it:

This link is the only one in this list not in sorted order (I know, incredibly pedantic, but my stupid brain needs things to match, hahaha). Can we move it to the bottom?

.. _SmartSim-PR446: https://github.com/CrayLabs/SmartSim/pull/446
.. _SmartSim-PR448: https://github.com/CrayLabs/SmartSim/pull/448
.. _SmartSim-PR451: https://github.com/CrayLabs/SmartSim/pull/451
Expand Down
1 change: 1 addition & 0 deletions tests/backends/test_dbmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ def create_tf_cnn():

def save_torch_cnn(path, file_name):
n = PyTorchNet()
n.eval()
example_forward_input = torch.rand(1, 1, 28, 28)
module = torch.jit.trace(n, example_forward_input)
torch.jit.save(module, path + "/" + file_name)
Expand Down
Loading