-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eval() to remove Torch warnings during testing #472
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #472 +/- ##
===========================================
- Coverage 90.77% 90.72% -0.06%
===========================================
Files 60 60
Lines 3837 3837
===========================================
- Hits 3483 3481 -2
- Misses 354 356 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @mellis13, thanks for chasing it down.
98537c4
to
ee54e29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One VERY small comment, but nothing worth holding approval up over. LGTM!! Thanks for squashing those warnings!!
doc/changelog.rst
Outdated
@@ -42,7 +45,7 @@ Detailed Notes | |||
all of SmartSim's machine learning backends with Python 3.11. | |||
(SmartSim-PR451_) (SmartSim-PR461_) | |||
|
|||
|
|||
.. _SmartSim-PR472: https://github.com/CrayLabs/SmartSim/pull/472 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredibly minor detail, but its going to bug me if I don't mention it:
This link is the only one in this list not in sorted order (I know, incredibly pedantic, but my stupid brain needs things to match, hahaha). Can we move it to the bottom?
When running the SmartSim test suite with the Torch backend installed, warnings are surfaced as shown below:
This appears to stem from not having the
eval()
function invoked before jit tracing and saving the model. It appears after adding this call that warnings no longer appear.