Add support for Mac OSX on Apple Silicon #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattToast
requested changes
Jan 29, 2024
Add Python 3.11 to SmartSim [ committed by @MattToast ] [ reviewed by @ashao ]
Relax the required version of `typing_extensions` [ committed by @MattToast ] [ reviewed by @ankona ]
This PR merges in github actions for running checks - black and isort [ reviewed by @MattToast ] [ committed by @amandarichardsonn ]
This PR adds Python type hinting to RunSettings.colocated_db_settings. [ reviewed by @MattToast ] [ committed by @amandarichardsonn ]
This PR fixes the `test_logs.py::test_context_leak` test that was erroneously creating a directory named `some value` in SmartSim's root directory.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #465 +/- ##
===========================================
+ Coverage 90.43% 90.72% +0.28%
===========================================
Files 60 60
Lines 3837 3837
===========================================
+ Hits 3470 3481 +11
+ Misses 367 356 -11 |
MattToast
requested changes
Jan 30, 2024
MattToast
approved these changes
Jan 31, 2024
doc/changelog.rst
Outdated
| @@ -41,13 +43,17 @@ Detailed Notes | |||
| there is now an available ONNX wheel for use with Python 3.10, and wheels for | |||
| all of SmartSim's machine learning backends with Python 3.11. | |||
| (SmartSim-PR451_) (SmartSim-PR461_) | |||
| - SmartSim can now be built and used on platforms using Apple Silicon | |||
| (ARM64). Currently, only the pyTorch backend is supported. Note that libtorch | |||
There was a problem hiding this comment.
Re-surfacing this pyTorch -> PyTorch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new ml_lib_builder repository we can now ship a version of libtorch that is compiled for Mac OSX on Apple Silicon (arm64). This PR explicitly allows ARM64 as an allowed architecture and creates variants fo the PTArchive class for Linux and Mac operating systems.