Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_logs to prevent generation of dir #467

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

al-rigazzi
Copy link
Collaborator

This PR fixes the test_logs.py::test_context_leak test that was erroneously creating a directory named some value in SmartSim's root directory.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50aa382) 90.80% compared to head (cafc489) 90.31%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #467      +/-   ##
===========================================
- Coverage    90.80%   90.31%   -0.50%     
===========================================
  Files           60       60              
  Lines         3829     3829              
===========================================
- Hits          3477     3458      -19     
- Misses         352      371      +19     

see 8 files with indirect coverage changes

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for cleaning up the clutter!!

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the mess I left behind me!

@al-rigazzi al-rigazzi merged commit 7803f4d into CrayLabs:develop Jan 30, 2024
34 checks passed
ashao pushed a commit to ashao/SmartSim that referenced this pull request Jan 30, 2024
This PR fixes the `test_logs.py::test_context_leak` test that was
erroneously creating a directory named `some value` in SmartSim's root
directory.
@al-rigazzi al-rigazzi deleted the fix_test_logs branch January 31, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants