Skip to content

Commit

Permalink
Remove wait associated with Experiment start summary (#298)
Browse files Browse the repository at this point in the history
Remove the wait associated with the Experiment start summary.

[ committed by @mellis13 ]
[ reviewed by @billschereriii ]
  • Loading branch information
mellis13 authored Jun 7, 2023
1 parent 5fd3598 commit d4f7df8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
3 changes: 3 additions & 0 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Description

A full list of changes and detailed notes can be found below:

- Remove wait time associated with Experiment launch summary
- Update and rename Redis conf file
- Migrate from redis-py-cluster to redis-py
- Update full test suite to not require a TF wheel at test time
Expand All @@ -36,6 +37,7 @@ A full list of changes and detailed notes can be found below:

Detailed notes

- Remove wait time associated with Experiment launch summary (PR298_)
- Update Redis conf file to conform with Redis v7.0.5 conf file (PR293_)
- Migrate from redis-py-cluster to redis-py for cluster status checks (PR292_)
- Update full test suite to no longer require a tensorflow wheel to be available
Expand All @@ -51,6 +53,7 @@ codes. These have now all been updated. (PR284_)
- Orchestrator and Colocated DB now accept a list of interfaces to bind to. The
argument name is still `interface` for backward compatibility reasons. (PR281_)

.. _PR298: https://github.com/CrayLabs/SmartSim/pull/298
.. _PR293: https://github.com/CrayLabs/SmartSim/pull/293
.. _PR292: https://github.com/CrayLabs/SmartSim/pull/292
.. _PR291: https://github.com/CrayLabs/SmartSim/pull/291
Expand Down
12 changes: 0 additions & 12 deletions smartsim/experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -814,17 +814,5 @@ def _launch_summary(self, manifest):

logger.info(summary)

wait, steps = 10, 100
prog_bar = trange(
steps,
desc="Launching in...",
leave=False,
ncols=80,
mininterval=0.25,
bar_format="{desc}: {bar}| {remaining} {elapsed}",
)
for _ in prog_bar:
time.sleep(wait / steps)

def __str__(self):
return self.name

0 comments on commit d4f7df8

Please sign in to comment.