Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse reply helpers #502

Merged
merged 28 commits into from
Oct 26, 2021
Merged

Parse reply helpers #502

merged 28 commits into from
Oct 26, 2021

Commits on Oct 20, 2021

  1. Add first impl using prost

    @maurolacy
    maurolacy committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    7e52f64 View commit details
    Browse the repository at this point in the history

  2. Add manual protobuf decoding

    @maurolacy
    maurolacy committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    18ddb76 View commit details
    Browse the repository at this point in the history

  3. Add protobuf parsing helpers

    @maurolacy
    maurolacy committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    ce22a9c View commit details
    Browse the repository at this point in the history

  4. Add length checks / avoid panic

    @maurolacy
    maurolacy committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    16dbb2d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Add length-prefixed field protobuf parser

    @maurolacy
    maurolacy committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    f14dec1 View commit details
    Browse the repository at this point in the history

  2. Add parse_reply_execute_data helper

    @maurolacy
    maurolacy committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    bb4baad View commit details
    Browse the repository at this point in the history

  3. Add empty instantiate data check

    @maurolacy
    maurolacy committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    0cee15a View commit details
    Browse the repository at this point in the history

  4. Add field number to parse protobuf helpers

    @maurolacy
    maurolacy committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    ad1cc93 View commit details
    Browse the repository at this point in the history

  5. Add protobuf base128 varint decoding

    @maurolacy
    maurolacy committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    3390286 View commit details
    Browse the repository at this point in the history

  6. Fix protobuf base128 varint decoding 

    Add high-level varint decoding tests
    @maurolacy
    maurolacy committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    9b69ce0 View commit details
    Browse the repository at this point in the history

  7. Define the expected data explicitly

    @maurolacy
    maurolacy committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    82449eb View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary / extra bit shifts

    @maurolacy
    maurolacy committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    1e1e19b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. Add string works tests

    @maurolacy
    maurolacy committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    ff25971 View commit details
    Browse the repository at this point in the history

  2. Add string errs tests 

    Fix protobuf string parser: message too short
    @maurolacy
    maurolacy committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    489133b View commit details
    Browse the repository at this point in the history

  3. Add bytes works tests

    @maurolacy
    maurolacy committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    68f2121 View commit details
    Browse the repository at this point in the history

  4. Add varint and length prefixed tests

    @maurolacy
    maurolacy committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    4d29b4c View commit details
    Browse the repository at this point in the history

  5. Use protobuf encoding helper for bytes tests

    @maurolacy
    maurolacy committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    4abee6a View commit details
    Browse the repository at this point in the history

  6. Use protobuf encoding helper for string

    @maurolacy
    maurolacy committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    ed54fb8 View commit details
    Browse the repository at this point in the history

  7. Fix empty string case

    @maurolacy
    maurolacy committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    6885041 View commit details
    Browse the repository at this point in the history

  8. Consolidate string tests

    @maurolacy
    maurolacy committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    2c81a96 View commit details
    Browse the repository at this point in the history

  9. Use slice instead of vec

    @maurolacy
    maurolacy committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    36e4e10 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Merge branch 'main' into 480-reply-parsing-helpers

    @maurolacy
    maurolacy authored Oct 25, 2021
    Configuration menu
    Copy the full SHA
    e478292 View commit details
    Browse the repository at this point in the history

  2. Simplify varint computation

    @maurolacy
    maurolacy committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    ec2f741 View commit details
    Browse the repository at this point in the history

  3. Avoid split_off when possible

    @maurolacy
    maurolacy committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    2153df7 View commit details
    Browse the repository at this point in the history

  4. Avoid unnecessary conversion

    @maurolacy
    maurolacy committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    13ca025 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Merge branch 'main' into 480-reply-parsing-helpers

    @maurolacy
    maurolacy authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    41a57ae View commit details
    Browse the repository at this point in the history

  2. Update prost to latest version 

    Co-authored-by: Jakub Bogucki <[email protected]>
    @maurolacy @ueco-jb
    maurolacy and ueco-jb committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    ad1aa5f View commit details
    Browse the repository at this point in the history

  3. Update lock file

    @maurolacy
    maurolacy committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a442d7c View commit details
    Browse the repository at this point in the history