Parse reply helpers #502
Merged
Parse reply helpers #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
reviewed
Oct 21, 2021
There was a problem hiding this comment.
Nice work.
A few comments on improving checks on the production code (it works for most, but has some limits it doesn't error on).
And a few cleanup requests for the tests. Testing parse_protobuf_string and parse_protobuf_bytes as units is more important. You can ignore the "table test" setup comments for now if it is a lot of work. Can be follow up sometime, mainly a comment in general as I see you adopting this pattern (which I know well from Go)
maurolacy
force-pushed
the
480-reply-parsing-helpers
branch
from
9c6ad8f
to
3390286
Compare
Add high-level varint decoding tests
Fix protobuf string parser: message too short
Merged
ethanfrey
previously approved these changes
Oct 25, 2021
ueco-jb
approved these changes
Oct 26, 2021
Co-authored-by: Jakub Bogucki <[email protected]>
maurolacy
force-pushed
the
480-reply-parsing-helpers
branch
from
0c8b944
to
a442d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #480.
Events helpers not implemented, but they don't require protobuf, so, can be deserialized directly. In any case, we can add them in a follow-up.