Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugged my fork in the README #329

Closed
wants to merge 1 commit into from

Conversation

rustygentile
Copy link

Hi Corentin,

I was able to get your code up and running with SageMaker. Any chance you could add a link to my fork in your README? It might help others who are having trouble with the installation. Thanks again for leaving this project up.

Best regards,
Rusty

@ghost
Copy link

ghost commented Jul 3, 2020

Hi, I checked out your fork and what you've accomplished is neat. It's nicely documented too. But with CPU support added (#366) and webrtcvad now optional (#375) the major pain points are resolved.

May I suggest that you open an issue plugging your Sagemaker fork and we can refer people to it if they have difficulties with the installation?

@rustygentile
Copy link
Author

@blue-fish , hey, thanks for the feedback! I've submitted issue #398. I'll be sure to checkout the latest changes. I can probably get the cost of running this in the cloud down too now that there's CPU support.

@ghost
Copy link

ghost commented Oct 14, 2020

This is too niche for inclusion in README.md but as of now we still have #398 open. That will give visibility to your work for those who are still unable to install the toolbox on their system for whatever reason.

@ghost ghost closed this Oct 14, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant