Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make webrtcvad optional for inference #375

Closed
ghost opened this issue Jun 24, 2020 · 1 comment
Closed

Make webrtcvad optional for inference #375

ghost opened this issue Jun 24, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 24, 2020

Second thing: webrtcvad. That package is hell to install on windows. There are alternatives for noise removal out there. There's also the possibility of not using it at all, but for both LibriSpeech and LibriTTS I would recommend it.

Propose making webrtcvad completely optional for running demo_cli.py. This would make it a lot easier for Windows users who just want to try cloning a voice with the pretrained models. It would continue to be used when preprocessing audio files for training.

An optional import of webrtcvad could be done using something like this: https://stackoverflow.com/a/52826085

@ghost
Copy link
Author

ghost commented Jun 26, 2020

Resolved by #376

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants