feat(schedule): derive auditable schedule outcomes - #517
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Rebuild the schedule-outcome child on the exact current #515 hierarchy head, preserving the parent OpenCode/NIM and release-note protections while retaining only the bounded outcome-domain source, tests, coverage registration, and documentation delta.
Strengthen the published-release regression so stacked reconciliation cannot silently delete the GitHub Pages deployment/operator note from the immutable 1.0.0 changelog section.
Restore the immutable 1.0.0 GitHub Pages deployment/operator release note removed during stacked semantic reconciliation. The preceding regression commit locks this published note against future parent/child rebuilds.
Rebuild the terminal reason authorization/audit child on the exact current #517 outcome-domain head, retaining parent release-note and NVIDIA NIM/OpenCode protections while preserving only the bounded reason-event domain, tests, coverage registration, and doctoring delta.
Restore the current #515 hierarchy/orchestrator tree while retaining only the bounded schedule-outcome delta. Preserve tenant-bound orchestrator attribution source/tests/docs and combine package/changelog registrations without transferring stale parent content.
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 similar comment
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Buyer outcome
Refs #287. This bounded stacked slice adds a framework-neutral schedule-outcome derivation domain above the four-level hierarchy parent. It distinguishes observed execution facts from versioned early/on-time/late, in-progress, blocked, skipped, cancelled, and not-performed interpretations without silently treating missing evidence as failure.
Exact current stack and scope
feat/work-item-hierarchy-domain-287@36c11dd0bf907569184d7d73172b675d21bd0ff1;73ce4227d761c79a9fcad39b0455fec4b35b6274;74db28396ac304ddd103cbf4efe6fb28b36005dc;CHANGELOG.md,docs/doctoring/schedule-outcome-domain.md,package.json,server/schedule_outcome_domain.mjs,tests/unit/changelog-release-notes.test.mjs,tests/unit/coverage-script-contract.test.mjs,tests/unit/schedule-outcome-domain.test.mjs, andtests/unit/schedule-outcome-domain-edge.test.mjs;Earlier parent movement was reconciled non-destructively and stale inherited bytes that would have removed or weakened parent orchestrator attribution behavior were restored. Any future parent/head movement invalidates stack-sensitive evidence until parent→child semantics are freshly reconciled.
Outcome contract
not_started,in_progress,completed_early,completed_on_time,completed_late,not_performed,skipped,cancelled, andblockedunder explicit derivation versionschedule-outcome/v1;Zor numeric UTC offset so deployment-local timezone parsing cannot change the represented instant;TDD and current repair evidence
The current-head repair follows an executable RED → fix sequence for Devin's timezone-ambiguity finding:
3bfa11fb96270fd3a0802dba222f62e45d35ef38added realistic reason-event and blocker regressions proving offset-less audit timestamps were still accepted; hosted Server Tests run32755033364failed inschedule-outcome-domain-edge.test.mjswithMissing expected exception.73ce4227d761c79a9fcad39b0455fec4b35b6274changed the production timestamp boundary to require an explicitZor±HH:MMoffset before parsing.32808080518is terminal success on the PR's synthetic parent→child merge revisiond871e3a6c720e3e9f537c1aaa923e16bd5af2b79;unit-and-apijob97681961662ran both schedule-domain suites and specifically passedrequires explicit timezone offsets for auditable timestampstogether with the surrounding contract tests. That is strong product-behavior evidence for the repaired stack, but it is not immutable-contributor-head merge authority because the current repository workflow still checks out the synthetic merge revision until fix(ci): execute Server Tests on exact PR heads #523 integrates.32808080524and OSV Scanner32808080762are also terminal run-level success for this current head/stack generation.All four current review threads are resolved after verification: the offset-less timestamp defect is fixed and executable GREEN exists; blocker ordering is offset-safe; the UTC-day future-date behavior is intentional under
schedule-outcome/v1; and explicit terminal reason-event precedence is the documented taxonomy policy while underlying execution/blocker facts remain in the immutable explanation. None of these model/informational submissions constitutes a qualifying independent approval.The PR remains stacked and must not integrate independently of #515. Organization default-branch required-workflow authority must be regenerated only after the parent is protected-shipped and this slice is reconciled onto the resulting live
develophead; current stacked-branch success cannot be transferred across that restack.Standards and integration boundary
docs/doctoring/schedule-outcome-domain.mddistinguishes active-PR design from protected shipped truth and records source facts, derivation versioning, uncertainty/missingness boundaries, rollback, and research/standards traceability. ScopeWeave's taxonomy is a product contract; it is not represented as a verbatim ISO or PMI taxonomy.This PR does not close #287. Subsequent authorization, persistence, API/UI, variance, forecasting, and decision-view slices remain separate.
Merge gate
Do not integrate before #515. After the parent reaches protected
develop, reconcile this exact bounded semantic diff onto the resulting live head and regenerate every then-applicable repository and organization CI/browser E2E/owned statement-branch-function-line coverage/docstring/CodeQL/SAST/security/dependency/supply-chain/package/provenance/required-workflow gate on the unchanged restacked head. ScopeWeave #523 andContextualWisdomLab/.github#1222remain the repository-native and organization-reusable exact-head evidence-control owners. Valid unresolved defects must remain zero and the live default-branch pull-request rule must be satisfied by one qualifying independent current-head approval under active ruleset18156473; that ruleset does not require latest-push approval. Synthetic/predecessor/status-only/model-only evidence cannot authorize integration.Refs #287