Repository navigation
π¨ Palette: aria-disabled μμ±μ νμ©ν μ μ₯ λ²νΌ μ κ·Όμ± κ°μ λ° μμ ν νΌ μ μΆ λ³΄νΈ #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
4
commits into
develop
from
π¨-palette-ux-improvement-2170920320515867020
The head ref may contain hidden characters: "\u{1F3A8}-palette-ux-improvement-2170920320515867020"
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7da93d5
π¨ Palette: aria-disabled λμ disabledλ‘ λ³κ²½νμ¬ μ κ·Όμ± λ° μ μΆ μ΄λ²€νΈ 보νΈ
seonghobae 583b1fa
π‘οΈ Sentinel: MEDIUM μ·¨μ½μ μμ μ μν΄ @hono/node-server λ° hono ν¨ν€μ§ μ
λ°μ΄νΈ
seonghobae 0747a2c
π‘οΈ Sentinel: MEDIUM μ·¨μ½μ μμ μ μν΄ @hono/node-server λ° hono ν¨ν€μ§ μ
λ°μ΄νΈ
seonghobae e6b091a
π‘οΈ Sentinel: MEDIUM μ·¨μ½μ μμ μ μν΄ @hono/node-server λ° hono ν¨ν€μ§ μ
λ°μ΄νΈ
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| const fs = require('fs'); | ||
| let content = fs.readFileSync('tests/e2e/scopeweave.spec.js', 'utf8'); | ||
| content = content.replace('});\n});\n\n test(\'ScopeWeave Planner - Palette UX Enhancements - blocks form submission when save button is aria-disabled\'', ' test(\'ScopeWeave Planner - Palette UX Enhancements - blocks form submission when save button is aria-disabled\''); | ||
| content += '});\n'; | ||
| fs.writeFileSync('tests/e2e/scopeweave.spec.js', content); | ||
|
github-actions[bot] marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ποΈ Data Integrity & Integration | π Major | β‘ Quick win
κ²μ¦μ κ°±μ ν λ€
aria-disabledλ₯Ό κ²μ¬ν΄μΌ ν©λλ€.μ λ ₯ μ§ν debounceκ° λλκΈ° μ μ μ μΆνλ©΄ μ΄ μμ μλ
aria-disabledκ° μμ§ μ κ±°λ μνμΌ μ μμ΅λλ€. μ΄νrenderDraftValidation.flush()κ° μ€λ₯λ₯Ό μ€μ ν΄λsaveEditor()κ° μ΄λ―Έ νΈμΆλμ΄ μλͺ»λ λ°μ΄ν°κ° μ μ₯λ©λλ€.flush()λ₯Ό νμ¬ guardλ³΄λ€ μμμ νΈμΆνμΈμ. νμ¬ E2E ν μ€νΈλ μμ± κ°±μ μ κΈ°λ€λ¦° λ€ ν΄λ¦νλ―λ‘ μ΄ κ²½ν©μ κ²μΆνμ§ λͺ»ν©λλ€.μμ μμ
π Committable suggestion
π€ Prompt for AI Agents