-
Notifications
You must be signed in to change notification settings - Fork 0
π¨ Palette: aria-disabled μμ±μ νμ©ν μ μ₯ λ²νΌ μ κ·Όμ± κ°μ λ° μμ ν νΌ μ μΆ λ³΄νΈ #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "\u{1F3A8}-palette-ux-improvement-2170920320515867020"
Changes from all commits
7da93d5
583b1fa
0747a2c
e6b091a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,14 +26,14 @@ python3 -m http.server 4173 # open http://127.0.0.1:4173 | |
|
|
||
| # Cloud server (Node >= 22 β uses node:sqlite) | ||
| npm install | ||
| npm run server # API + static client on :8787 | ||
| pnpm run server # API + static client on :8787 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π Maintainability & Code Quality | π‘ Minor | β‘ Quick win λ¬Έμμ μ€μΉ λͺ λ Ήλ pnpm κΈ°μ€μΌλ‘ ν΅μΌν΄ μ£ΌμΈμ. μ€ν λͺ
λ Ήλ§ pnpmμΌλ‘ λ³κ²½λκ³ κ° Cloud κ°λ° μλ΄μ μ€μΉ λͺ
λ Ήμ
π Affects 2 files
π€ Prompt for AI Agents |
||
|
|
||
| # Tests | ||
| npm run test:unit # pure-math: EVM/S-curve, CPM, baselines, workload, β¦ | ||
| npm run test:api # API smoke (authΒ·tenancyΒ·RBACΒ·billingΒ·webhooks) + rate limit | ||
| npm run test:e2e # Playwright UI suite (auto-starts http.server on :4173) | ||
| npm run test:e2e:cloud # cloud UI spec only | ||
| npm run fuzz # fast-check property fuzz (node --test tests/fuzz/*.mjs) | ||
| pnpm run test:unit # pure-math: EVM/S-curve, CPM, baselines, workload, β¦ | ||
| pnpm run test:api # API smoke (authΒ·tenancyΒ·RBACΒ·billingΒ·webhooks) + rate limit | ||
| pnpm run test:e2e # Playwright UI suite (auto-starts http.server on :4173) | ||
| pnpm run test:e2e:cloud # cloud UI spec only | ||
| pnpm run fuzz # fast-check property fuzz (node --test tests/fuzz/*.mjs) | ||
| python3 -m pytest tests/config # workflow-ownership / governance checks | ||
|
|
||
| # Single test: unit tests are plain Node scripts | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -408,6 +408,13 @@ function bindTableEvents(renderDraftValidation, updateEditorDraftFromEvent) { | |||||||||||||||||||||||||
| return; | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
| event.preventDefault(); | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| const submitBtn = form.querySelector('button[type="submit"]'); | ||||||||||||||||||||||||||
| if (submitBtn && submitBtn.getAttribute('aria-disabled') === 'true') { | ||||||||||||||||||||||||||
| showToast(submitBtn.title || 'νμ¬ μ¬μ©ν μ μλ κΈ°λ₯μ λλ€.'); | ||||||||||||||||||||||||||
| return; | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
Comment on lines
+412
to
+417
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ποΈ Data Integrity & Integration | π Major | β‘ Quick win κ²μ¦μ κ°±μ ν λ€ μ
λ ₯ μ§ν debounceκ° λλκΈ° μ μ μ μΆνλ©΄ μ΄ μμ μλ μμ μμ event.preventDefault();
+ renderDraftValidation.flush();
const submitBtn = form.querySelector('button[type="submit"]');
if (submitBtn && submitBtn.getAttribute('aria-disabled') === 'true') {
showToast(submitBtn.title || 'νμ¬ μ¬μ©ν μ μλ κΈ°λ₯μ
λλ€.');
return;
}
- renderDraftValidation.flush();
saveEditor();π Committable suggestion
Suggested change
π€ Prompt for AI Agents |
||||||||||||||||||||||||||
| renderDraftValidation.flush(); | ||||||||||||||||||||||||||
| saveEditor(); | ||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||
|
|
@@ -1047,7 +1054,11 @@ function renderEditorValidation() { | |||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| const saveButton = form.querySelector('button[type="submit"]'); | ||||||||||||||||||||||||||
| if (saveButton) { | ||||||||||||||||||||||||||
| saveButton.disabled = errors.length > 0; | ||||||||||||||||||||||||||
| if (errors.length > 0) { | ||||||||||||||||||||||||||
| saveButton.setAttribute('aria-disabled', 'true'); | ||||||||||||||||||||||||||
| } else { | ||||||||||||||||||||||||||
| saveButton.removeAttribute('aria-disabled'); | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
| saveButton.title = errors.length > 0 ? 'μ λ ₯κ°μ μ¬λ°λ₯΄κ² μμ ν΄μΌ μ μ₯ν μ μμ΅λλ€.' : 'μ μ₯ (Enter)'; | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π©Ί Stability & Availability | π Major | β‘ Quick win
π§© Analysis chain
π Script executed:
Repository: ContextualWisdomLab/scopeweave
Length of output: 594
π Script executed:
Repository: ContextualWisdomLab/scopeweave
Length of output: 285
π Script executed:
Repository: ContextualWisdomLab/scopeweave
Length of output: 6517
π Web query:
actions/setup-node pnpm packageManager corepack pnpm install without pnpm/action-setup GitHub Actionsπ‘ Result:
You can use pnpm in GitHub Actions without the
pnpm/action-setupaction by utilizing Corepack, which is bundled with modern Node.js distributions [1]. To do this, follow these steps in your workflow: 1. Setup Node.js usingactions/setup-node[2]. 2. Enable Corepack within your workflow steps. 3. Runpnpm install. Example configuration: jobs: build: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: node-version: 22 - name: Enable Corepack run: corepack enable - name: Install dependencies run: pnpm install Key Considerations: - Corepack Versioning: It is recommended to update Corepack to the latest version before enabling it, as the version bundled with older Node.js releases may contain bugs or outdated signatures [3][1]. You can do this by runningnpm install --global corepack@latestbeforecorepack enable[1]. - Caching: Theactions/setup-nodeaction provides acache: 'pnpm'input [2]. While this is the official way to cache dependencies, it expectspnpmto be present in the environment. When using Corepack, you must ensure it is enabled before theactions/setup-nodestep or configure your workflow to handle the cache manually usingactions/cacheif needed, assetup-nodemight attempt to resolve the pnpm executable before it is available [2][4]. - Modern Alternative: The pnpm team has released a new action,pnpm/setup[5], which is designed to replaceactions/setup-nodefor pnpm workflows by installing both the package manager and the required Node.js runtime (viadevEngines.runtime) in one step, effectively making traditional setup actions unnecessary for many use cases [5].Citations:
π Script executed:
Repository: ContextualWisdomLab/scopeweave
Length of output: 247
pnpmμ λͺ μμ μΌλ‘ μ΄κΈ°ννμΈμ.
package.jsonμpackageManager: "pnpm@10.30.3"λ₯Ό μ μΈνμ§λ§,fuzz.ymlκ³Όserver-tests.ymlμ΄λμλ pnpm bootstrapμ΄ μμ΄pnpm installμ΄ runner μνμ μμ‘΄ν©λλ€..github/workflows/fuzz.yml:40-47βcache: npmμ pnpmμ©μΌλ‘ λ§μΆκ³pnpm install --frozen-lockfileλ‘ κ³ μ νμΈμ..github/workflows/server-tests.yml:28-33,48-53β λ job λͺ¨λ κ°μ pnpm μ΄κΈ°νμ frozen installμ΄ νμν©λλ€.π Affects 2 files
.github/workflows/fuzz.yml#L47-L47(this comment).github/workflows/server-tests.yml#L33-L33.github/workflows/server-tests.yml#L53-L53π€ Prompt for AI Agents