feat(audit): add bounded snapshot manifests - #84
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Review exact current source head |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base="0d3366de78c6b1373588d682560d3d50a6ee8a9a"
head="d2fee308e48cc963a195fb6d52846a70fe46cf63"
echo "== checked-out commit =="
git rev-parse HEAD
echo "== requested commits =="
git rev-parse "$base"
git rev-parse "$head"
echo "== merge base / ancestry =="
git merge-base "$base" "$head"
git rev-list --left-right --count "$base...$head"
echo "== changed files =="
git diff --name-status "$base" "$head"
echo "== diff stat =="
git diff --stat "$base" "$head"
echo "== Python outlines in changed files =="
git diff --name-only "$base" "$head" -- '*.py' |
while IFS= read -r file; do
echo "-- $file"
ast-grep outline "$file" --lang python --items all || true
done
echo "== focused transaction and digest references =="
rg -n -i -C 3 \
'repeatable read|serializable|read.?only|transaction|snapshot|keyset|max.?events|overflow|sha-?256|digest|manifest|timestamp|microsecond|tenant' \
$(git diff --name-only "$base" "$head" -- '*.py' '*.md' '*.yml' '*.yaml' '*.toml') || true
echo "== complete diff =="
git diff --find-renames --find-copies --minimal "$base" "$head"Length of output: 125776 🏁 Script executed: #!/bin/bash
set -euo pipefail
base="0d3366de78c6b1373588d682560d3d50a6ee8a9a"
head="d2fee308e48cc963a195fb6d52846a70fe46cf63"
echo "== exact revision evidence =="
printf 'HEAD: '; git rev-parse HEAD
printf 'BASE: '; git rev-parse "$base"
printf 'REQUESTED_HEAD: '; git rev-parse "$head"
printf 'MERGE_BASE: '; git merge-base "$base" "$head"
printf 'AHEAD_BEHIND: '; git rev-list --left-right --count "$base...$head"
echo "== checkpoint_audit.py outline =="
ast-grep outline pg_llm_batch/checkpoint_audit.py --lang python --items all
echo "== event model, row decoding, and page traversal =="
sed -n '1,330p' pg_llm_batch/checkpoint_audit.py
sed -n '480,700p' pg_llm_batch/checkpoint_audit.py
echo "== manifest tests, full focused sections =="
sed -n '1,380p' tests/test_checkpoint_audit_snapshot_manifest.py
sed -n '1,320p' tests/test_checkpoint_audit_snapshot_transaction_boundary.py
sed -n '1,280p' tests/test_checkpoint_audit_snapshot_integration.py
echo "== pagination implementation and manifest call sites =="
rg -n -C 8 \
'def list_audit_event_page_in_transaction|def list_audit_event_page|SELECT|ORDER BY|before_audit_event_id|build_audit_snapshot_manifest_in_transaction' \
pg_llm_batch/checkpoint_audit.py tests
echo "== all changed test names =="
git diff --name-only "$base" "$head" -- 'tests/*.py' |
while IFS= read -r file; do
echo "-- $file"
rg -n '^def test_|^class Test' "$file" || true
doneLength of output: 184340
I verified the checked-out head and merge base. The head is one commit ahead and zero commits behind the requested stacked base. I found no source defects in the requested scope. The implementation:
The new focused tests cover the transaction boundary, overflow behavior, fixed schema-v1 digest compatibility, page-size invariance, and a live concurrent-insert case. The reported exact-head CI and Release Acceptance successes are consistent with the staged evidence. Protected-
|
|
Superseded by #97, which rebuilds this snapshot-manifest feature on the current #96 pagination predecessor and preserves the later pagination/key-revalidation stack before composing the snapshot implementation. This branch remains on stale #83 ancestry, so its checks/reviews cannot become final integration evidence. Closing unmerged to keep one canonical snapshot-manifest line; no evidence transfers to #97. |
1 participant
Linearized replacement for #66
This Draft replays the exact checkpoint-audit snapshot-manifest delta onto replacement pagination predecessor #83 exact head
0d3366de78c6b1373588d682560d3d50a6ee8a9a.RCA and replacement boundary
Old #66 remained based on superseded #65 history. Replacement #83 reproduces #65's exact 12-file feature result on the current stack. All #66-modified baseline files inherited from #65 were therefore exact by construction; the two additional existing targets outside that replay (
.github/workflows/ci.ymlandtests/test_checkpoint_audit_ci_contract.py) were independently verified byte-identical between old #65 and #83 before replay. No force-push, conflict-side selection, or hand-edited merge resolution was used.Replacement head
d2fee308e48cc963a195fb6d52846a70fe46cf63is exactly one commit ahead and zero behind exact current #83 head0d3366de78c6b1373588d682560d3d50a6ee8a9aand reproduces #66's exact 16-file delta and aggregate1887additions /26deletions. It preserves the strict active read-only REPEATABLE READ/SERIALIZABLE transaction boundary, bounded event/page limits, fail-closed overflow, page-partition-invariant schema-v1 digest framing, fixed compatibility vector, live PostgreSQL concurrency checks, public API, and authoritative ADR/operator/assurance documentation.Old #66 is closed unmerged as superseded. No predecessor-head check, review, or approval transfers.
Current exact-head staged evidence
d2fee308e48cc963a195fb6d52846a70fe46cf63.0d3366de78c6b1373588d682560d3d50a6ee8a9a(feat(audit): add bounded stable export pages #83).31286925728: completed / success on this exact source head.31286925720: completed / success on this exact source head.5229592582verified this exact head/base and reported no source defects in the requested transaction, pagination, overflow, digest-framing, timestamp, and assurance scope. The service also reported its review quota was rate-limited, so that comment is useful automated review evidence but not a formal review or independent approval.This is current stacked-stage evidence only. Default-branch-only organization/security/review gates are not inferred as passing while this PR remains stacked.
Dependency and merge boundary
Required order remains
.github#790 -> pg-llm-batch#53 -> #55 -> #56 -> #57 -> #58 -> #59 -> #60 -> #78 -> #79 -> #80 -> #83 -> this PR.Keep Draft while earlier prerequisites remain unintegrated. After every prerequisite safely reaches protected
main, reconcile or retarget this slice onto the actual integrated base and regenerate all required exact-head/exact-base CI, live PostgreSQL, migration/rollback/concurrency, security, dependency, SBOM/provenance, packaging, automated-review, branch-protection, repository-policy, and Release Acceptance gates. Merge only with zero unresolved valid findings and a qualifying independent non-author GitHubAPPROVEDreview on the unchanged final head. Queued, pending, failed, cancelled, skipped-required, neutral-required, absent, stale-head/base, predecessor, status-only, author-only, or synthetic-only evidence is never acceptance.